Repository navigation
Conversation
jorgsowa
marked this pull request as ready for review
October 18, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP_XXH64Init()emits the "Passing a seed of a type other than int is deprecated" notice whenever an options array is passed, even if it has noseedkey:xxh32, xxh3 and xxh128 don't do this. The xxh64 check was
if (seed && IS_LONG == Z_TYPE_P(seed)) … else deprecate, so a missing seed fell into the else branch. This PR nests the check the same way as inPHP_XXH32Init().Introduced in #15236 (74eff98), so 8.4 is the first affected version.