Repository navigation
Conversation
sxe_get_gc() reported only the properties table, so a cycle closed through sxe->tmp (the value behind a reference to a missing property) or through sxe->iter.data (the current iteration element) was never collected, nor was one through a foreach iterator, whose get_gc slot was NULL. Report all three. The other php_sxe_object fields hold strings or libxml state, and declared properties of subclasses are not writable from userland.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sxe_get_gc() reported only the properties table, so a cycle through the value behind a reference to a missing property (
$r =& $sxe->missing; $r = $sxe;), through the current iteration element, or through a foreach iterator held by a suspended generator was never collected. It now also reports sxe->tmp and sxe->iter.data, and the iterator reports its data zval.