Repository navigation
Conversation
Simplyfing some clean-up code and name validation logic
Girgias
force-pushed
the
2026-10-zend_lookup_class_flags
branch
from
October 12, 2026 22:46
6798e05 to
177286c
Compare
Girgias
marked this pull request as ready for review
October 13, 2026 00:00
Member
Author
|
After discussion with Nora it is probably not worth trying to pass the lowercase string from See #24326 as the follow-up extracting the useful things out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
zend_lookup_class_with_flags()API so that we can refactorzend_lookup_class_ex()to always require a lowercase class name, moving the class name lowercaseing code to an outer call.This also adds assertions that the lowercase class name is usable as such, which would simplify the logic that I attempted in #24271