Skip to content

Fix OPcache releasing other threads' SHM locks under ZTS #24272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavimus wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
Open

Fix OPcache releasing other threads' SHM locks under ZTS #24272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ext/opcache/ZendAccelerator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,16 @@ static inline void accel_unlock_all(void)

mem_usage_unlock_all.l_type = F_UNLCK;
mem_usage_unlock_all.l_whence = SEEK_SET;
#ifdef ZTS
/* fcntl() locks belong to the process: unlocking the whole file would also release
* the SHM write lock (byte 0) and the restart lock (byte 2) held by other threads.
* Those are always released by the thread that took them. */
mem_usage_unlock_all.l_start = 1;
mem_usage_unlock_all.l_len = 1;
#else
mem_usage_unlock_all.l_start = 0;
mem_usage_unlock_all.l_len = 0;
#endif

if (fcntl(lock_file, F_SETLK, &mem_usage_unlock_all) == -1) {
zend_accel_error(ACCEL_LOG_DEBUG, "UnlockAll: %s (%d)", strerror(errno), errno);
Expand Down
Loading