ext/pgsql: Removed pg_service(), unavailable with any released libpq

NEWS

@@ -68,6 +68,7 @@ PHP                                                                        NEWS
 
 - PGSQL:
   . Fixed pg_lo_write() rejecting data containing null bytes. (Ilia Alshanetsky)
+  . Removed pg_service(), unavailable with any released libpq. (KentarouTakeda)
 
 - Readline:
   . Fixed a heap over-read in the interactive shell prompt when cli.prompt is

UPGRADING

@@ -782,7 +782,6 @@ PHP 8.5 UPGRADE NOTES
   . pg_close_stmt offers an alternative way to close a prepared
     statement from the DEALLOCATE sql command in that we can reuse
     its name afterwards.
-  . pg_service returns the ongoing service name of the connection.
 
 - Reflection:
   . ReflectionConstant::getFileName() was introduced.

ext/pgsql/config.m4

@@ -31,9 +31,6 @@ if test "$PHP_PGSQL" != "no"; then
   PHP_CHECK_LIBRARY([pq], [PQclosePrepared],
     [AC_DEFINE([HAVE_PG_CLOSE_STMT], [1], [PostgreSQL 17 or later])],,
     [$PGSQL_LIBS])
-  PHP_CHECK_LIBRARY([pq], [PQservice],
-    [AC_DEFINE([HAVE_PG_SERVICE], [1], [PostgreSQL 18 or later])],,
-    [$PGSQL_LIBS])
 
   old_CFLAGS=$CFLAGS
   CFLAGS="$CFLAGS $PGSQL_CFLAGS"

ext/pgsql/pgsql.c

@@ -922,7 +922,6 @@ PHP_FUNCTION(pg_close)
 #define PHP_PG_HOST 6
 #define PHP_PG_VERSION 7
 #define PHP_PG_JIT 8
-#define PHP_PG_SERVICE 9
 
 /* php_pgsql_get_link_info */
 static void php_pgsql_get_link_info(INTERNAL_FUNCTION_PARAMETERS, int entry_type)
@@ -1007,12 +1006,6 @@ static void php_pgsql_get_link_info(INTERNAL_FUNCTION_PARAMETERS, int entry_type
 			PQclear(res);
 			return;
 		}
-#if defined(HAVE_PG_SERVICE)
-		case PHP_PG_SERVICE: {
-			result = PQservice(pgsql);
-			break;
-		}
-#endif
 		EMPTY_SWITCH_DEFAULT_CASE()
 	}
 	if (result) {
@@ -1069,13 +1062,6 @@ PHP_FUNCTION(pg_jit)
 	php_pgsql_get_link_info(INTERNAL_FUNCTION_PARAM_PASSTHRU,PHP_PG_JIT);
 }
 
-#if defined(HAVE_PG_SERVICE)
-PHP_FUNCTION(pg_service)
-{
-	php_pgsql_get_link_info(INTERNAL_FUNCTION_PARAM_PASSTHRU,PHP_PG_SERVICE);
-}
-#endif
-
 /* Returns the value of a server parameter */
 PHP_FUNCTION(pg_parameter_status)
 {

ext/pgsql/pgsql.stub.php

@@ -508,9 +508,6 @@ function pg_version(?PgSql\Connection $connection = null): array {}
      */
     function pg_jit(?PgSql\Connection $connection = null): array {}
 
-#ifdef HAVE_PG_SERVICE
-    function pg_service(?PgSql\Connection $connection = null): string {}
-#endif
     /**
      * @param PgSql\Connection|string $connection
      * @refcount 1