Conversation
When the callback denies the push, or throws and leaves the return value undefined, libcurl destroys the easy handle itself, but the wrapper kept a stale ch->cp and never released the CurlHandle it had just created, so each denied push leaked one wrapper and permanently bumped the parent's clone counter. Factor the per-instance teardown out of curl_free_obj() into _php_curl_free_instance() and reuse it for the denied handle, clearing ch->cp first so the object dtor takes its constructor-failure exit instead of cleaning up twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the callback denies the push, or throws and leaves the return value undefined, libcurl destroys the easy handle itself, but the wrapper kept a stale ch->cp and never released the CurlHandle it had just created, so each denied push leaked one wrapper and permanently bumped the parent's clone counter. The per-instance teardown moves out of curl_free_obj() into _php_curl_free_instance(), reused for the denied handle with ch->cp cleared first so the object dtor takes its constructor-failure exit rather than cleaning up twice. The new test needs Caddy, so it only runs in the lanes that have it.