Conversation
fpm_status_export_to_zval() has a potential null derefence, and the sad paths of fpm_status_handle_request() a use-after-free plus several memory leaks.
1ma
force-pushed
the
fpm-status-leaks
branch
from
September 21, 2026 23:15
9ff0f32 to
d0f154b
Compare
Author
|
Sorry, changed target branch to PHP-8.4 since it's a simple bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential null dereference in
fpm_status_export_to_zval, one use-after-free and several memory leaks in the sad paths offpm_status_handle_requestthat I noticed after looking at #23808 with fresh eyes today.Since I expect it will take some time to review the OpenMetrics PR I thought I'd PR these small fixes separately. I haven't added any new tests because I don't know how to trigger none of these error conditions, open to suggestions.