ext/random: Use zend_bin2hex_str for little-endian random state serialization - #23821
Open
LamentXU123 wants to merge 2 commits into
Open
LamentXU123 wants to merge 2 commits into
LamentXU123 wants to merge 2 commits into
Conversation
LamentXU123
requested review from
TimWolla,
bukka,
devnexen and
zeriyoshi
as code owners
September 21, 2026 12:20
LamentXU123
commented
Sep 21, 2026
TimWolla
reviewed
Sep 21, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
I'm fairly confident that the BE implementation for random has become (much) slower.
TimWolla
reviewed
Sep 21, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Actually, probably most of them (but not sure how much it matter for the others).
Member
Author
|
Well I don't think about this performance-wise. It make sense to have regression. Then, let's turn this PR into that minor optimization and revert the hex2bin change. |
LamentXU123
changed the title
LamentXU123
requested review from
TimWolla
and removed request for
bukka,
devnexen and
zeriyoshi
September 21, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #23819