Skip to content

date: Fix unserialization of Time\Duration - #23629

Merged
TimWolla merged 1 commit into
php:masterfrom
TimWolla:time-duration-unserialize
Sep 15, 2026
Merged

TimWolla merged 1 commit into
php:masterfrom
TimWolla:time-duration-unserialize

Conversation

@TimWolla

@TimWolla TimWolla commented Sep 9, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread ext/date/time_duration.c Outdated
@TimWolla
TimWolla force-pushed the time-duration-unserialize branch from f3c7903 to 170fb17 Compare September 9, 2026 15:50

@derickr derickr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ext/date/time_duration.c Outdated
Comment thread ext/date/time_duration.c Outdated

@ndossche ndossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay except for the object_properties_load changes, I have attached a more complete patch to that PR.

Comment thread ext/date/time_duration.c
Comment thread ext/date/time_duration.c Outdated
Comment thread Zend/zend_API.c Outdated
Comment thread ext/random/randomizer.c
@TimWolla
TimWolla merged commit 00cc4fe into php:master Sep 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants