GH-22684: Make Reflection(Class)Constant::__toString() print booleans as booleans - #23548
Merged
DanielEScherzer merged 3 commits intoSep 22, 2026
Merged
Conversation
DanielEScherzer
force-pushed
the
reflection-print-booleans
branch
from
September 2, 2026 19:56
caaaa67 to
98c940c
Compare
Girgias
approved these changes
Sep 6, 2026
ndossche
requested changes
Sep 19, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Almost right. In favor of the change.
DanielEScherzer
force-pushed
the
reflection-print-booleans
branch
from
September 21, 2026 01:12
98c940c to
d385354
Compare
ndossche
approved these changes
Sep 21, 2026
Add regression tests for the output of `ReflectionClassConstant::__toString()` and `ReflectionConstant::__toString()` when the value of the constant is boolean `true` or `false`. The `true` cases are already covered by some existing tests, but it seems that the `false` cases are currently untested.
Updates the output of `ReflectionClassConstant::__toString()` and `ReflectionConstant::__toString()`, as well as the other ways that class constants are printed, e.g. `ReflectionClass::__toString()`.
DanielEScherzer
force-pushed
the
reflection-print-booleans
branch
from
September 22, 2026 20:24
d385354 to
77d4c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22684