Repository navigation
Run composer on the host, not in the sandbox - #342
Merged
Merged
Conversation
Package plugins and scripts never run, so no package code does. vendor is then just another file of the solution, so DockerSandbox drops its composer handling, the composer cache volume and vendorVolumes.
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of the simpler plan for #336: every sandbox run should be the same, so composer moves out of it.
Composerclass runs composer on this machine, always with--no-plugins --no-scripts, so no package code runs.PrepareSolutionListenerandReferencePackagesuse it.warm()now fills this machine's composer cache.DockerSandboxloses its composer handling, the composer cache volume andvendorVolumes(Let DockerSandbox keep vendor in a volume for listed folders #340).vendoris just part of the solution again, soComposerCheckworks as it always did.Checked with learn-you-php dependency-heaven verify,
SANDBOX=docker.