Repository navigation
Fix PHP 8.4/8.5 deprecations - #2
Merged
Merged
Conversation
…ions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…anguageToken::$inject property Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rnings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes keylighter run cleanly on PHP 8.4 and 8.5. Intended release: 0.8.5 (patch, no BC break).
?Typefor implicitly nullable parameters (PHP 8.4 deprecation), incl.highlight()infunctions.phpstr_replaceargument inTokenFactory::getNameand declareLanguageToken::$inject(dynamic property deprecation)^9.6in dev so the suite runs on 8.5 (PHPUnit 8 crashes there)PHP minimum unchanged (
^7.1.3 | ^8.0).Tested on PHP 8.5.12 with
error_reporting=-1: 128 tests, 205 assertions, 2 skipped (pre-existing), 0 deprecations.Known, not fixed: the Ruby language regex (
Language/Ruby.php:87) fails to compile on current PCRE2 — a runtime error, not a deprecation; PHP highlighting is unaffected.Unblocks
php-school/cli-md-renderer4.0 (commonmark 2) and php-workshop on PHP 8.5.🤖 Generated with Claude Code