Skip to content

feat: bundle enum consumer skill - #12

Merged
coisa merged 2 commits into
mainfrom
codex/bundled-consumer-skill
Oct 20, 2026
Merged

coisa merged 2 commits into
mainfrom
codex/bundled-consumer-skill

Conversation

@coisa

@coisa coisa commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Applications need a complete integration procedure for fast-forward/enum. Bundle resources/skills/fast-forward-enum with a supported ^0.2 contract, MIT license, executable examples and optional project/global installation guidance. Declare Composer discovery metadata and suggest llm/skills without adding a runtime installer; link the canonical source from README and the root AGENTS contract.

Validation:

  • Official skills-ref 0.1.0 at agentskills/agentskills@69ef37e validates the finished package.
  • Strict Composer metadata and committed Changelog contribution checks pass. Changelog was checked through the existing CLI source at e75a9be, using --since=origin/main --source=tags.
  • Git archive preserves the entire skill payload. Disposable Composer consumers install the candidate archive, and llm/skills 1.15.0 automatically copies only the narrowly trusted donor. Every payload file is compared byte for byte.
  • The complete PHPUnit suite passes on PHP 8.5.11: 88 tests / 237 assertions. Inline first-use instructions and packaged examples run on PHP 8.3.35 in a disposable CLI environment; Fork uses PCNTL/POSIX.
  • The broader DevTools pipeline has been exercised; this draft retains any remaining inherited tooling/style diagnostics for review rather than claiming a complete green gate. Final current checks are reported on the PR.

The declared minimum describes the release introducing the skill. Disposable path repositories label the exact candidate source with that version solely for validation; no release/tag is claimed or created. New integration/docs text is original, guided by source/tests; LICENSE uses the maintainer's established MIT terms. Native host discovery, session activation and fresh-model task performance remain unverified. No global host skills are installed. No merge or release is performed.

Additional lifecycle checks: automatic synchronization with --no-scripts, explicit update, auto-sync:false, installed-plugin suppression with --no-plugins, same-path overwrite, extra/unrelated-file retention and donor/plugin removal were exercised in disposable consumers. Guarded project and isolated-global copies refuse existing targets; update backup and rollback were tested. The pinned Skills CLI project add/list route works, but its removal can leave the canonical .agents/skills copy; the installation guide now documents that observed limitation. Final archive/installed/manager copies match the finished payload byte for byte.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5f603d74-7641-4676-a2bc-5ae7e60431e2
📥 Commits

Reviewing files that changed from the base of the PR and between f755fd5 and e1b841e.

📒 Files selected for processing: 9
  • .changelog/bundled-consumer-skill.md
  • AGENTS.md
  • README.md
  • composer.json
  • resources/skills/fast-forward-enum/LICENSE
  • resources/skills/fast-forward-enum/SKILL.md
  • resources/skills/fast-forward-enum/examples/integration.php
  • resources/skills/fast-forward-enum/references/installation.md
  • tests/ConsumerSkillTest.php
+-------------------------------------------------------------------+
| Find some code, review it up, all day long you'll have good luck! |
+-------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Changelog

✅ Contribution check passed.

Head: e1b841ef772b4ad58c5ee8d77d24ced7b6427bf0

Base: f755fd5a8237c7b79882bf444cf9ea50028d440b

Contribution: 1 new valid fragment(s). Policy: ordinary.

  • bundled-consumer-skill.md — added, minor

    Bundle the fast-forward-enum consumer skill with executable examples, optional installation guidance and Composer discovery metadata.

@github-actions

Copy link
Copy Markdown
Contributor

@coisa
coisa marked this pull request as ready for review October 20, 2026 20:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T20:27:22.832624Z e1b841e Draft marked ready
🔒 Security Review ✅ Completed 2026-10-20T20:28:41.252957Z e1b841e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Rigorous review requested

This pull request is ready for the dedicated review-guardian pass powered by $pull-request-review.

Review focus

  • Tests changed; confirm assertions still cover the touched behavior and edge cases.
  • Docs or README changed; verify commands, examples, and generated outputs stayed aligned.
  • Packaged agent surfaces changed; verify prompts, sync behavior, and inherited guidance.
  • Packaged resources changed; verify consumer repositories inherit the right defaults and generated artifacts.

Sample changed files

  • .changelog/bundled-consumer-skill.md
  • AGENTS.md
  • README.md
  • composer.json
  • resources/skills/fast-forward-enum/LICENSE
  • resources/skills/fast-forward-enum/SKILL.md
  • resources/skills/fast-forward-enum/examples/integration.php
  • resources/skills/fast-forward-enum/references/installation.md
  • tests/ConsumerSkillTest.php

Suggested prompt

Use $pull-request-review with the review-guardian agent to review PR #12 (https://github.com/php-fast-forward/enum/pull/12).
Lead with findings ordered by severity. Include repository file references whenever possible.
Prioritize bugs, regressions, missing tests, missing docs, generated-output drift, and workflow or CI impacts.
For workflow/action changes, record validation evidence or residual risk; pay special attention to GITHUB_TOKEN pushes and required-check dispatch/mirroring.
Base: main
Head: codex/bundled-consumer-skill @ e1b841e

@coisa
coisa merged commit 9ca28e5 into main Oct 20, 2026
60 of 61 checks passed
@coisa
coisa deleted the codex/bundled-consumer-skill branch October 20, 2026 20:26
github-actions Bot added a commit that referenced this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant