Skip to content

[config] Restore CI compatibility with the current toolchain - #361

Merged
coisa merged 3 commits into
mainfrom
codex/fix-ci-tool-api
Oct 6, 2026
Merged

coisa merged 3 commits into
mainfrom
codex/fix-ci-tool-api

Conversation

@coisa

@coisa coisa commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Related Issue

Fixes the CI regression reported by the maintainer. Failure evidence: tests and dependency health, reports.

Motivation / Context

Fresh dependency resolution broke tests, reports, and dependency health: ECS removed named preset parameters, Rector removed PhpLevelSetResolver, and Composer Audit rejects the abandoned rector/jack package.

Changes

  • Import a packaged ECS set that preserves Symfony, auto, legacy Symplify rules, and consumer customization using supported APIs.
  • Resolve PHP sets through Rector's public configuration builder and preserve mixed parameter documentation required by the PHPDoc pipeline.
  • Replace Jack with Rector Swiss Knife >=2.7 and preserve preview, upgrade, and threshold handling; forward --dev only where supported.
  • Add regression coverage and update dependency documentation and release notes.
  • Isolate temporary Git fixtures from the repository environment inherited by pre-commit hooks.
  • Apply the automatic Rector and style normalizations required by the complete repository gate.

Verification

  • composer dev-tools passed without --fix, including Rector, PHPDoc, ECS, and reports.
  • All 717 tests and 2,198 assertions passed; line coverage 91.83% against the 80% minimum. All GrumPHP pre-commit checks passed.
  • Reports command completed successfully, including tests, metrics, and API documentation.
  • Dependency health passed with --max-outdated=-1, both with and without --dev.
  • Composer Audit and strict Composer validation passed.
  • Fresh dependency resolution without a lock file or vendor directory passed with the PHP 8.3.0 platform and selected Swiss Knife 2.7.0.
  • Focused Rector, PHPDoc, and ECS checks passed for the integration changes.
  • GitHub tests (PHP 8.3, 8.4, 8.5), dependency health, wiki, changelog, reports, and preview verification passed on current PR head 41f9aae76d474bcae3d29df99ec6ab29a3d31a41, including the Swiss Knife minimum-version fix.

Documentation / Generated Output

  • README updated
  • docs/ updated
  • Generated reports reviewed locally; the new ECS resource remains included in package exports.

Changelog

  • Added a notable CHANGELOG.md entry

Reviewer Notes

Rector now requires ^2.6 so the configuration only references rules available in supported versions. Swiss Knife requires ^2.7: version 2.6 requires PHP >=8.4, while the validated 2.7 release supports the project's PHP 8.3 platform and includes the migrated dependency commands. Consumer workflow wrappers need no change. The workflow failures were caused by package integration APIs and dependency abandonment. Existing uncommitted Dependabot changes in the primary checkout were preserved.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f0952e09-2f6c-4796-b6ec-90f9afa123b0
📥 Commits

Reviewing files that changed from the base of the PR and between f2dbd18 and 41f9aae.

📒 Files selected for processing (84)
  • .github/wiki
  • CHANGELOG.md
  • README.md
  • bin/dev-tools.php
  • composer.json
  • docs/commands/dependencies.rst
  • docs/links/dependencies.rst
  • docs/running/specialized-commands.rst
  • resources/ecs/php-cs-fixer.php
  • src/Changelog/Checker/UnreleasedEntryChecker.php
  • src/Changelog/Parser/ChangelogParser.php
  • src/Changelog/Renderer/MarkdownRenderer.php
  • src/CodeOwners/CodeOwnersGenerator.php
  • src/Composer/Json/ComposerJson.php
  • src/Config/ComposerDependencyAnalyserConfig.php
  • src/Config/ECSConfig.php
  • src/Config/RectorConfig.php
  • src/Console/Command/DependenciesCommand.php
  • src/Console/Command/DocsCommand.php
  • src/Console/Command/GitAttributesCommand.php
  • src/Console/Command/MetricsCommand.php
  • src/Console/Command/TestsCommand.php
  • src/Console/Command/UpdateComposerJsonCommand.php
  • src/Console/Command/WikiCommand.php
  • src/Console/DevTools.php
  • src/Console/Input/HasCacheOption.php
  • src/Console/Input/HasJsonOption.php
  • src/Console/Logger/OutputFormatLogger.php
  • src/Console/Logger/Processor/CommandInputProcessor.php
  • src/Console/Logger/Processor/CommandOutputProcessor.php
  • src/Console/Output/OutputCapabilityDetector.php
  • src/Container/ServiceProvider/DevToolsServiceProvider.php
  • src/Filesystem/Filesystem.php
  • src/Funding/FundingYamlCodec.php
  • src/Git/GitClient.php
  • src/GitAttributes/Writer.php
  • src/Path/WorkingProjectPathResolver.php
  • src/PhpUnit/Coverage/CoverageSummaryLoader.php
  • src/Process/XdebugDisablingProcessEnvironmentConfigurator.php
  • src/Project/ProjectCapabilitiesResolver.php
  • src/Rector/RemoveEmptyDocBlockRector.php
  • src/Resource/FileDiffer.php
  • src/Resource/UnifiedDiffer.php
  • src/SelfUpdate/ComposerSelfUpdateScopeResolver.php
  • src/SelfUpdate/ComposerVersionChecker.php
  • src/SelfUpdate/WorkingDirectorySwitcher.php
  • tests/Composer/Json/ComposerJsonTest.php
  • tests/Config/ComposerDependencyAnalyserConfigTest.php
  • tests/Config/ECSConfigTest.php
  • tests/Config/RectorConfigTest.php
  • tests/Console/Command/AgentsCommandTest.php
  • tests/Console/Command/CommandAttributeCompatibilityTest.php
  • tests/Console/Command/CopyResourceCommandTest.php
  • tests/Console/Command/DependenciesCommandTest.php
  • tests/Console/Command/FundingCommandTest.php
  • tests/Console/Command/GitAttributesCommandTest.php
  • tests/Console/Command/GitHooksCommandTest.php
  • tests/Console/Command/LicenseCommandTest.php
  • tests/Console/Command/MetricsCommandTest.php
  • tests/Console/Command/SkillsCommandTest.php
  • tests/Console/Command/TestsCommandTest.php
  • tests/Console/Command/UpdateComposerJsonCommandTest.php
  • tests/Console/Command/WikiCommandTest.php
  • tests/Console/Logger/OutputFormatLoggerTest.php
  • tests/Console/Output/OutputCapabilityDetectorTest.php
  • tests/Environment/EnvironmentTest.php
  • tests/Filesystem/FilesystemTest.php
  • tests/Funding/ComposerFundingCodecTest.php
  • tests/GitAttributes/ReaderTest.php
  • tests/GitHooks/PackagedHooksTest.php
  • tests/GitHubActions/RefreshPreviewPointerActionTest.php
  • tests/GitHubActions/ResolvePredictableConflictsActionTest.php
  • tests/GitHubActions/RetryTransientFailuresActionTest.php
  • tests/GitHubActions/SetupComposerActionTest.php
  • tests/GitIgnore/GitIgnoreTest.php
  • tests/GitIgnore/MergerTest.php
  • tests/GitIgnore/ReaderTest.php
  • tests/Path/DevToolsPathResolverTest.php
  • tests/Path/WorkingProjectPathResolverTest.php
  • tests/PhpUnit/Coverage/CoverageSummaryLoaderTest.php
  • tests/PhpUnit/Event/TestSuite/JoliNotifExecutionFinishedSubscriberTest.php
  • tests/Process/ProcessQueueTest.php
  • tests/Project/ProjectCapabilitiesResolverTest.php
  • tests/ServiceProvider/DevToolsServiceProviderTest.php
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T17:29:23.561856Z a2c1ac0 PR opened
🔒 Security Review ✅ Completed 2026-10-05T17:27:07.983526Z a2c1ac0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2c1ac0510

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread composer.json Outdated
@coisa
coisa merged commit d8c500f into main Oct 6, 2026
34 checks passed
@coisa
coisa deleted the codex/fix-ci-tool-api branch October 6, 2026 19:14
github-actions Bot added a commit that referenced this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

1 participant