fix(mobile): maps: stricter arguments, clearer names, docstrings and types

[petercorke]

What

The map classes (OccGrid.py, landmarkmap.py): entries 15-17 of the typing-pass problem list and what a review of the two files turned up. Builds on the workspace resolver (#776).

Fixed

• BaseMap and the occupancy grids swallowed unknown keyword arguments, so BinaryOccupancyGrid(g, size=0.1) was accepted and ignored (the argument is cellsize). It is now a TypeError.
• A grid with neither an array nor a workspace failed later with AttributeError; it is a ValueError at construction (entry 16).
• PolygonMap.iscollision is documented to accept an ndarray but crashed on one; it now wraps it in a Polygon2.
• LandmarkMap.plot dropped its whole default style as soon as any keyword was given; options are now merged over LANDMARK_STYLE.
• A NumPy integer was rejected as a landmark count.
• set() documented the region as [xmin, ymin, xmax, ymax]; the code (and now the docstring) use [xmin, xmax, ymin, ymax], as for a workspace.

Renamed (old names still work)

• dx, dy are replaced by width, height properties.
• w2g, g2w, line_w become world_to_grid, grid_to_world, line_world; the short names are kept as plain aliases (used in PoseGraph.py).
• LandmarkMap(map=...) becomes LandmarkMap(landmarks=...); map= is a deprecated keyword. The first positional argument is unchanged.
• LandmarkMap(verbose=...) had no effect and is deprecated.

Not touched: negative-index wrap in BinaryOccupancyGrid.isoccupied, which contributor PR #769 fixes.

Docstrings and types

ArrayLike2, ArrayLike4, R2, R4, Points2; typos; missing docstrings added (PolygonMap.plot, the __str__ and __repr__ methods); stale __main__ demos and lgtm comments removed.

Full suite 1077 passed (with both compiled extensions), mypy clean.

🤖 Generated with Claude Code

[codacy-production]

Not up to standards ⛔

🔴 Issues 2 high

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category	Results
ErrorProne	2 high

View in Codacy

🟢 Metrics 17 complexity · 2 duplication

Metric	Results
Complexity	17
Duplication	2

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (84a07d2) to head (bc537b2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/roboticstoolbox/mobile/OccGrid.py	0.00%	38 Missing ⚠️
src/roboticstoolbox/mobile/landmarkmap.py	0.00%	22 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #779   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        144     144           
  Lines      14712   14729   +17     
=====================================
- Misses     14712   14729   +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.