Repository navigation
test(mobile): pin the behaviour of the plot style arguments - #777
Merged
Merged
Conversation
Headless (Agg) tests of the style arguments of the planner, PRM and EKF plotting methods, ahead of renaming them to <thing>_style. Two expected failures record defects found while writing them: PlannerBase.plot ignores path_marker, and EKF.plot_map uses the wrong covariance block for every ellipse after the first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
🟢 Metrics 35 complexity · 1 duplication
Metric Results Complexity 35 Duplication 1
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 14689 14689
=====================================
Misses 14689 14689 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Headless (Agg) tests of the Matplotlib style arguments of the planner, PRM and EKF plotting methods in
roboticstoolbox.mobile. They pin down what each argument does today, so that the planned renaming (<thing>_style, old names deprecated, petercorke/rvc-ecosystem#15) and the merging of user styles over defaults can be made safely.Coverage
line,line_r), start and goal markers, and that a user's dict currently replaces the defaults rather than mergingvertexandedgestyles, and that the dicts passed are not modifiedEKF.plot_xy(format string and keywords),plot_map(marker,ellipse) andplot_ellipseTwo expected failures
They record defects found while writing the tests; each flips to a failure when the defect is fixed, which is the cue to remove the marker.
PlannerBase.plotacceptspath_markerandpath_marker_reversebut never reads them (the path is drawn fromline/line_r). The book's figure scriptsfig5_16.pyandfig5_20.pypasspath_marker=, so they are drawn in the default style (Rename RTB plot style arguments to <thing>_style in figure scripts RVC3-python#55).EKF.plot_map(ellipse=...)takes the covariance blockP_est[i:i+2, i:i+2]for landmarki; it should be rows and columns2i..2i+2(plus 3 when the vehicle is estimated), so ellipses after the first are wrong.No library code is changed.
🤖 Generated with Claude Code