Repository navigation
chore(typing): annotate the tools, models, demo, ets and robot packages - #768
Merged
Merged
Conversation
DHFactor and trajectory stay on the to-do list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The five ETS models that depend on the typing of the ets package stay on the to-do list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
BaseETS is generic over its element type, replacing the overloads on self. The five ETS models that depended on it come off the to-do list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
DHFactor stays on the to-do list: it is not used anywhere. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 73 high |
| Security | 1 high |
🟢 Metrics 0 complexity · 7 duplication
Metric Results Complexity 0 Duplication 7
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 143 143
Lines 14594 14785 +191
======================================
- Misses 14594 14785 +191 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next steps of the type hinting pass, one commit per area: tools, demo/bin/models, ets, robot.
disallow_untyped_defs, apart from the ones left on the mypy to-do list:tools/trajectory.py(the open fix(trajectory): normalize quintic profile time #736),mobile/ParticleFilter.py(the open fix(mobile): use circular particle heading moments #735), the two unusedDHFactormodules and a stale test file insidetools/urdf/tests.BaseETSis now generic over its element type (BaseETS[ET]forETS,BaseETS[ET2]forETS2), which replaces the overloads onselfthat mypy rejects as invalid.ets[i]is anET,ets[a:b]anETS.# type: ignorecomments left over from the pyright pass were unused and are removed.roboticstoolbox.ets.ETS,robot.Link) the imports are explicit.EKF.map-style attribute typos,isinstance(camera, "Robot"),np.inftyremoved in NumPy 2,Connector._add_teach_panelmissing). The real bugs found are left for the end of the pass.mypy clean on the whole package, 923 tests pass locally (the 19 that need the compiled extensions fail in a source worktree as they do on main).
🤖 Generated with Claude Code