Repository navigation
fix: preserve organization tile contrast - #149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
All changed behavior is covered by the new
OrgTileregression test and real-browser verification in both light and dark themes.Tests: 134 → 135 test files (+1 new)
Coverage gate: PASS (100% of changed paths).
Pre-Landing Review
No issues found. Independent adversarial reviews also found no issues.
Design Review
The first implementation used an important utility. The final implementation fixes specificity at the dropdown rule instead, with no remaining findings.
Eval Results
No prompt-related files changed, so evals were skipped.
Plan Completion
No plan file was detected.
Verification Results
bun run test: 1,176 passed, 0 failedbun run typecheck: passedbun run lint: passed, with one pre-existing Fast Refresh warningbun run build: passedoklch(0.205 0 0), initialoklch(0.985 0 0)oklch(0.922 0 0), initialoklch(0.205 0 0)Test plan