Skip to content

fix: preserve organization tile contrast - #149

Merged
arnestrickmann merged 1 commit into
mainfrom
arnestrickmann/fix-org-logo-hover
Oct 23, 2026
Merged

arnestrickmann merged 1 commit into
mainfrom
arnestrickmann/fix-org-logo-hover

Conversation

@arnestrickmann

Copy link
Copy Markdown
Contributor

Summary

  • keep organization initials on their paired foreground color while dropdown rows are focused or hovered
  • add a reusable dropdown-child opt-out for components with their own foreground/background pairing
  • add a regression test for organization tiles

Test Coverage

All changed behavior is covered by the new OrgTile regression test and real-browser verification in both light and dark themes.

Tests: 134 → 135 test files (+1 new)
Coverage gate: PASS (100% of changed paths).

Pre-Landing Review

No issues found. Independent adversarial reviews also found no issues.

Design Review

The first implementation used an important utility. The final implementation fixes specificity at the dropdown rule instead, with no remaining findings.

Eval Results

No prompt-related files changed, so evals were skipped.

Plan Completion

No plan file was detected.

Verification Results

  • bun run test: 1,176 passed, 0 failed
  • bun run typecheck: passed
  • bun run lint: passed, with one pre-existing Fast Refresh warning
  • bun run build: passed
  • Chromium light theme: tile oklch(0.205 0 0), initial oklch(0.985 0 0)
  • Chromium dark theme: tile oklch(0.922 0 0), initial oklch(0.205 0 0)

Test plan

  • Open Account with two organizations
  • Open the organization switcher
  • Hover the non-active organization in light and dark themes
  • Confirm its initial remains readable against the tile

@arnestrickmann
arnestrickmann merged commit e62e4d0 into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant