Repository navigation
chore(deps): switch from deprecated dependency in main branch - #12701
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update CSS tooling dependency and import packages/react-core/package.json, packages/react-core/scripts/copyStyles.mjs |
The package replaces the css development dependency with @adobe/css-tools. The style-copy script imports the parser and stringifier from @adobe/css-tools. Processing logic is unchanged. |
Test timezone setting
| Layer / File(s) | Summary |
|---|---|
Change the test script timezone package.json |
The test script now sets TZ=America/New_York. The locale and Jest command remain unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Other
Possibly related PRs
- patternfly/patternfly-react#12698: Both PRs change the root test script timezone setting. This PR uses
America/New_York, while that PR usesEtc/GMT+5.
Merge Risk: 
27d87
-
No concrete merge-blocking risk remains in the reviewed changes.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately summarizes the primary change: replacing the deprecated CSS dependency with the suggested @adobe/css-toolspackage. It is concise and specific.Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
CSS is no longer being maintained and suggested switching to @adobe version.
bf2e1cc to
503ea36
Compare
|
Preview: https://pf-react-pr-12701.surge.sh A11y report: https://pf-react-pr-12701-a11y.surge.sh |
rebeccaalpert
changed the title
Since Oct 29 the Unit tests job fails 3 timezone-dependent Timestamp tests on every PR. The root test script runs jest with TZ=EST, and GitHub's ubuntu-latest image migrated from ubuntu-24.04 to ubuntu-26.04 between the last passing run (Oct 27) and the first failure (Oct 29); on the newer image TZ=EST no longer applies the UTC-5 offset and jest runs as UTC instead. EST is a legacy POSIX-style abbreviation rather than an IANA zone. America/New_York is identical to EST (UTC-5, standard time) for every date used in the Timestamp tests (all in January/February), so no expected values change. Full suite passes: 396 suites, 3902 tests, 914 snapshots.
CSS is no longer being maintained and suggested switching to @adobe version.
What: Closes #
Additional issues:
Summary by CodeRabbit