Repository navigation
refactor: Bump typescript-eslint from 8.64.0 to 8.66.0 - #957
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update TypeScript-ESLint dependency versions package.json, package-lock.json |
The development dependency and its locked TypeScript-ESLint packages advance to 8.66.0. The plugin’s nested ignore resolution advances to 7.0.14. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Merge Risk: 
4abb8
-
This dependency-only update introduces no identified application or runtime risk.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title begins with the allowed prefix "refactor:" and uses a capitalized first word after the prefix. It accurately describes the dependency update from typescript-eslint 8.64.0 to 8.66.0. Linked Issues check Issue #929requirestypescript-eslint8.64.0 to 8.66.0.package.jsonpinstypescript-eslintto8.66.0.package-lock.jsonupdates the root dependency and the resolvedtypescript-eslintpack…Out of Scope Changes check The reviewed diff changes only package.jsonandpackage-lock.json. The changes update the requested development dependency and its regenerated lock entries. The nestedignoreupdate is a depende…Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Security Check PASS. The pull request changes only the pinned dev dependency and its lockfile entries. The lockfile uses npm registry URLs and integrity hashes, and all changed packages are marked dev-only. Head and… Engage In Review Feedback No review feedback comments or actionable findings were provided. The engagement requirement is therefore not applicable. Full details: Linked Issues check
-
Explanation
Issue
#929requirestypescript-eslint8.64.0 to 8.66.0.package.jsonpinstypescript-eslintto8.66.0.package-lock.jsonupdates the root dependency and the resolvedtypescript-eslintpackage family to8.66.0, including the required dependency references. The change satisfies the stated coding requirement.
Full details: Out of Scope Changes check
-
Explanation
The reviewed diff changes only
package.jsonandpackage-lock.json. The changes update the requested development dependency and its regenerated lock entries. The nestedignoreupdate is a dependency resolution consequence of that update. No unrelated application code or public API changes are present.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: Security Check
-
Explanation
PASS. The pull request changes only the pinned dev dependency and its lockfile entries. The lockfile uses npm registry URLs and integrity hashes, and all changed packages are marked dev-only. Head and base
npm audit --package-lock-onlyresults are identical: 33 advisories, with none affectingtypescript-eslint, its scoped packages, orignore. No new security issue is introduced by this pull request.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Closes #929
Bumps
typescript-eslintfrom 8.64.0 to 8.66.0. It is a dev dependency used for linting and stays pinned exactly. This replaces the Dependabot PR, with the lock file regenerated on the currentmaster.Changes
typescript-eslint,@typescript-eslint/eslint-plugin,@typescript-eslint/parser): reject TypeScript 7 (feat: add warning when TS 7 is detected typescript-eslint/typescript-eslint#12529). The release notes call this a warning, but the shipped code throws. When the TypeScript major version is 7 or higher, each of these packages logs an error and throwstypescript-eslint does not support TS 7.0.when it loads.@typescript-eslint/eslint-plugin): deprecate theno-restricted-importsextension rule (feat(eslint-plugin): [no-restricted-imports] deprecate extension rule typescript-eslint/typescript-eslint#12527)@typescript-eslint/eslint-plugin):no-shadowreports a specialized error for enum declaration and member shadowing (feat(eslint-plugin): [no-shadow] specialized error on enum declaration and member shadowing typescript-eslint/typescript-eslint#12578)@typescript-eslint/parser): add theonUnsupportedTypeScriptVersionoption (error,warnorignore; defaultwarn), and deprecate the existingwarnOnUnsupportedTypeScriptVersionoption in its favor. Passing both options throws (feat(parser): add onUnsupportedTypeScriptVersion option to error on unsupported TypeScript versions typescript-eslint/typescript-eslint#12465).@typescript-eslint/typescript-estree): throw on invalidimport defersyntax (feat(typescript-estree): throw for invalid import defer syntax typescript-eslint/typescript-eslint#12552)@typescript-eslint/eslint-plugin):prefer-string-starts-ends-withhandles regex literals that end with an escaped$(fix(eslint-plugin): [prefer-string-starts-ends-with] handle escaped $ ending regex literals typescript-eslint/typescript-eslint#12515)@typescript-eslint/eslint-plugin):unbound-methodreports unbound methods accessed through a member expression on union types (fix(eslint-plugin): [unbound-method] report unbound methods accessed via member expression on union types typescript-eslint/typescript-eslint#12448)@typescript-eslint/eslint-plugin):no-unnecessary-parameter-property-assignmentno longer flags computed assignments with a variable key (fix(eslint-plugin): [no-unnecessary-parameter-property-assignment] don't flag computed assignments with a variable key typescript-eslint/typescript-eslint#12568)@typescript-eslint/typescript-estree): handleimport.defer()asImportExpression(feat(typescript-estree): handle import.defer() as ImportExpression typescript-eslint/typescript-eslint#12609)@typescript-eslint/eslint-plugin):no-unnecessary-type-conversionignores shadowed built-ins (fix(eslint-plugin): [no-unnecessary-type-conversion] ignore shadowed built-ins typescript-eslint/typescript-eslint#12590)@typescript-eslint/eslint-plugin):prefer-nullish-coalescinghandles shadowedBooleancalls (fix(eslint-plugin): [prefer-nullish-coalescing] handle shadowed Boolean calls typescript-eslint/typescript-eslint#12591)@typescript-eslint/eslint-plugin):no-useless-default-assignmentno longer reports defaults used by other overloads (fix(eslint-plugin): [no-useless-default-assignment] don't report defaults used by other overloads typescript-eslint/typescript-eslint#12607)@typescript-eslint/eslint-plugin):no-unnecessary-type-parameterschecksMappedTypekey remapping (fix(eslint-plugin): [no-unnecessary-type-parameters] check MappedType key remapping typescript-eslint/typescript-eslint#12588)@typescript-eslint/eslint-plugin):class-literal-property-stylekeeps type annotations and decorators (fix(eslint-plugin): [class-literal-property-style] preserve type annotations and don't drop decorators typescript-eslint/typescript-eslint#12617)onUnsupportedTypeScriptVersionin the parser options (fix(website): listonUnsupportedTypeScriptVersionin parser options typescript-eslint/typescript-eslint#12585)typescript-eslintpackage itself has no code changes in 8.66.0. It is a version bump to align with the other packages.There were no patch releases between these versions. npm's
latestis now 8.72.0, but this PR stays on Dependabot's target, 8.66.0.Breaking Changes
None
Code Changes Required
None. Only
package.jsonandpackage-lock.jsonchange.Impact on Linting
eslint --print-config, includingjs.configs.recommendedandtseslint.configs.recommended) enables 20@typescript-eslintrules. None of the rules changed in this range is among them.import deferis not used anywhere.typescriptpeer range>=4.8.4 <6.1.0already excludes TypeScript 7.eslint.config.mjssets neitheronUnsupportedTypeScriptVersionnor the deprecatedwarnOnUnsupportedTypeScriptVersion, so the parser option change does not affect this repository.npm ci --ignore-scripts, theneslint .without cache). Both 8.64.0 and 8.66.0 lint 10 files with 0 errors and 0 warnings, with no new or removed findings. The effective rule set is identical apart from the plugin and parser versions.eslint^8.57.0 || ^9.0.0 || ^10.0.0(10.7.0) andtypescript>=4.8.4 <6.1.0(6.0.3). The Nodeenginesrange of all 11 packages is unchanged:^18.18.0 || ^20.9.0 || >=21.1.0.Enabled typescript-eslint rules (identical on both versions)
ban-ts-comment,no-array-constructor,no-duplicate-enum-values,no-empty-object-type,no-explicit-any,no-extra-non-null-assertion,no-misused-new,no-namespace,no-non-null-asserted-optional-chain,no-require-imports,no-this-alias,no-unnecessary-type-constraint,no-unsafe-declaration-merging,no-unsafe-function-type,no-unused-expressions,no-unused-vars,no-wrapper-object-types,prefer-as-const,prefer-namespace-keyword,triple-slash-referenceRules changed in this range, none of them enabled:
no-restricted-imports,no-shadow,prefer-string-starts-ends-with,unbound-method,no-unnecessary-parameter-property-assignment,no-unnecessary-type-conversion,prefer-nullish-coalescing,no-useless-default-assignment,no-unnecessary-type-parameters,class-literal-property-styleLock File
typescript-eslintand its 10@typescript-eslint/*packages (eslint-plugin,parser,project-service,scope-manager,tsconfig-utils,type-utils,types,typescript-estree,utils,visitor-keys) move from 8.64.0 to 8.66.0. Their third-party dependency ranges are unchanged.node_modules/@typescript-eslint/eslint-plugin/node_modules/ignoremoves from 7.0.6 to 7.0.14:ignore@^7.0.5, and npm resolves the updated plugin's nested dependency to the newest version in that range.no-restricted-importsrule usesignore, and this repository does not enable it.ignore(node_modules/ignore, 5.3.2) is unchanged.gitand improve performance. The matching changes cover backslash escapes, trailing spaces, bracket expressions with POSIX character classes,/**patterns, andcheckIgnore()followinggit check-ignore.licensefields of the entries it changed, and it keptignoreat 7.0.6. This lock was generated on the currentmasterwith npm 10.9.3 and keeps thelicensefields.Summary by CodeRabbit