metro: Re-enable ignition-flash, packrat, power, thermal - #2701
Open
jamesmunns wants to merge 1 commit into
Open
jamesmunns wants to merge 1 commit into
jamesmunns wants to merge 1 commit into
Conversation
jamesmunns
changed the title
labbott
force-pushed
the
labbott/metro_sequencer_hf
branch
from
September 18, 2026 16:23
aefdf6a to
cc5ec3a
Compare
jamesmunns
force-pushed
the
james/seq-further-2
branch
from
September 18, 2026 17:08
4ab6b06 to
c66bed4
Compare
labbott
approved these changes
Sep 18, 2026
labbott
left a comment
labbott
left a comment
Collaborator
There was a problem hiding this comment.
Minor comments but overall LGTM
| #[cfg(feature = "cosmo")] | ||
| cosmo_bufs: cosmo::StaticBufs, | ||
| #[cfg(any(feature = "cosmo", feature = "metro"))] | ||
| sp5_bufs: cosmo_metro::StaticBufs, |
Comment on lines
+97
to
+100
| #[cfg(feature = "cosmo")] | ||
| userlib::task_slot!(SEQUENCER, cosmo_seq); | ||
| #[cfg(feature = "metro")] | ||
| userlib::task_slot!(SEQUENCER, metro_seq); |
Collaborator
There was a problem hiding this comment.
It feels a little goofy to need both of these but maybe that's a refactoring task later?
Comment on lines
+49
to
+52
| #[cfg(feature = "cosmo")] | ||
| const NUM_TMP451_SENSORS: usize = sensors::NUM_TMP451_TEMPERATURE_SENSORS; | ||
| #[cfg(feature = "metro")] | ||
| const NUM_TMP451_SENSORS: usize = 0; |
Collaborator
There was a problem hiding this comment.
Is there a comment to explain this beyond "we sure did decide to not have any TMP451 sensors"
Member
There was a problem hiding this comment.
The TMP451 on Cosmo is the T6 temperature sensor:
Lines 983 to 986 in f6e5849
So, this wouldn't be included on Metro as there's no T6.
Collaborator
There was a problem hiding this comment.
ahhhhh yeah that makes sense. It's just looks weird in the code here without that context.
Contributor
Author
There was a problem hiding this comment.
I'll add a note about this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and enable some more features