Repository navigation
feat(system-builder): try a draft's rest on a made-up character (4f6a) - #230
Merged
Merged
Conversation
systemBuilder/tryRest.js and POST /api/systems/try-rest (main admin, as the builder's other routes): one of a draft's rests through the game's own rules (resting.js), the made-up character's formulas worked out before and after (a draft whose formulas don't compile yet runs as typed), previewed with dice waiting or rolled only for roll: true, answering the character after, what wore off and the dice-log line the game would write. For TRY IT's CALL A REST and the RESTS page's ON THE SAMPLE (4f6c).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemBuilder/tryRest.js and POST /api/systems/try-rest (main admin, as the builder's other routes): one of a draft's rests through the game's own rules (resting.js), the made-up character's formulas worked out before and after (a draft whose formulas don't compile yet runs as typed), previewed with dice waiting or rolled only for roll: true, answering the character after, what wore off and the dice-log line the game would write. For TRY IT's CALL A REST and the RESTS page's ON THE SAMPLE (4f6c).
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues