Repository navigation
feat(system-builder): rests in the builder, as logic (4f3) - #226
Merged
Merged
Conversation
frontend sheets/rests.ts mirrors the server's rests.js for the RESTS page and the GAME tab: - restList / restsOf / restCount: the standard four with edits and switches, then a system's own; offered as the server offers them. - withRest stores only what differs; withNewRest up to 12; withoutRest leaves nothing counting as, or ending at, the deleted rest. - countedAs and makesLoop, in the order the server runs them. - refillTargets: health under the model (up by only where it heals by amounts, tracks named), the sheet's refillable numbers and the sections with maximums, from the previewed sheet; describeRefill, fitRefill, withRefill / withNewRefill (20 at most) / withoutRefill. - wearsOff / withWearsOff: the same switch as AT A REST on CONDITIONS. conditions.ts reads and writes the third ending, ends: 'rest' with at, dropping the rests when switched to another ending. Every rule held to the server's own code in sheets/__tests__/rests.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend sheets/rests.ts mirrors the server's rests.js for the RESTS page and the GAME tab:
conditions.ts reads and writes the third ending, ends: 'rest' with at, dropping the rests when switched to another ending.
Every rule held to the server's own code in sheets/tests/rests.test.ts.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues