Skip to content

feat(system-builder): rests in the builder, as logic (4f3) - #226

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4f3-rests-logic
Oct 9, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4f3-rests-logic

Conversation

@over2take

Copy link
Copy Markdown
Owner

frontend sheets/rests.ts mirrors the server's rests.js for the RESTS page and the GAME tab:

  • restList / restsOf / restCount: the standard four with edits and switches, then a system's own; offered as the server offers them.
  • withRest stores only what differs; withNewRest up to 12; withoutRest leaves nothing counting as, or ending at, the deleted rest.
  • countedAs and makesLoop, in the order the server runs them.
  • refillTargets: health under the model (up by only where it heals by amounts, tracks named), the sheet's refillable numbers and the sections with maximums, from the previewed sheet; describeRefill, fitRefill, withRefill / withNewRefill (20 at most) / withoutRefill.
  • wearsOff / withWearsOff: the same switch as AT A REST on CONDITIONS.

conditions.ts reads and writes the third ending, ends: 'rest' with at, dropping the rests when switched to another ending.

Every rule held to the server's own code in sheets/tests/rests.test.ts.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

frontend sheets/rests.ts mirrors the server's rests.js for the RESTS
page and the GAME tab:

- restList / restsOf / restCount: the standard four with edits and
  switches, then a system's own; offered as the server offers them.
- withRest stores only what differs; withNewRest up to 12; withoutRest
  leaves nothing counting as, or ending at, the deleted rest.
- countedAs and makesLoop, in the order the server runs them.
- refillTargets: health under the model (up by only where it heals by
  amounts, tracks named), the sheet's refillable numbers and the
  sections with maximums, from the previewed sheet; describeRefill,
  fitRefill, withRefill / withNewRefill (20 at most) / withoutRefill.
- wearsOff / withWearsOff: the same switch as AT A REST on CONDITIONS.

conditions.ts reads and writes the third ending, ends: 'rest' with at,
dropping the rests when switched to another ending.

Every rule held to the server's own code in sheets/__tests__/rests.test.ts.
@over2take
over2take merged commit a5ade41 into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4f3-rests-logic branch October 9, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant