Skip to content

feat(system-builder): call a rest at the table (4f2b); fix CWN's LONG… - #225

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4f2b-call-a-rest
Oct 9, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4f2b-call-a-rest

Conversation

@over2take

Copy link
Copy Markdown
Owner

…_REST

GET /api/sheets/rests lists the running custom system's rests that are on (none for a built-in game). POST /api/sheets/rest calls or previews one: { rest, players: true | [names], npcs: [token ids], preview }. The GM and granted editors, as with the built-in rest buttons.

  • sheets/rests.js: who rests (player characters in the running system, every one or the named ones whatever their case, each with its first token; chosen NPC tokens with the sheet linked to them in this game, or none). A preview rolls and writes nothing. Calling one works each sheet out inside its write queue, formulas worked out, so two rests at once both land and a player's edit is kept; then the token's health and conditions (a player's onto every token of theirs), one dice-log line each, and every screen told.
  • resting.js: restLine and restDice, the log line and its dice.
  • runtime.js: definitionOf.

Fix: CWN's LONG_REST had written SR6's Edge (edge = edge_max) onto CWN sheets since 821dae0 moved the resets onto the write queue, so it recovered no strain while reporting that it had. It takes 1 System Strain off every CWN sheet with some again, now with a test. The stray edge values it left behind are harmless and left as they are.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

…_REST

GET /api/sheets/rests lists the running custom system's rests that are
on (none for a built-in game). POST /api/sheets/rest calls or previews
one: { rest, players: true | [names], npcs: [token ids], preview }. The
GM and granted editors, as with the built-in rest buttons.

- sheets/rests.js: who rests (player characters in the running system,
  every one or the named ones whatever their case, each with its first
  token; chosen NPC tokens with the sheet linked to them in this game,
  or none). A preview rolls and writes nothing. Calling one works each
  sheet out inside its write queue, formulas worked out, so two rests
  at once both land and a player's edit is kept; then the token's
  health and conditions (a player's onto every token of theirs), one
  dice-log line each, and every screen told.
- resting.js: restLine and restDice, the log line and its dice.
- runtime.js: definitionOf.

Fix: CWN's LONG_REST had written SR6's Edge (edge = edge_max) onto CWN
sheets since 821dae0 moved the resets onto the write queue, so it
recovered no strain while reporting that it had. It takes 1 System
Strain off every CWN sheet with some again, now with a test. The stray
edge values it left behind are harmless and left as they are.
@over2take
over2take merged commit 64a6449 into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4f2b-call-a-rest branch October 9, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant