Repository navigation
feat(system-builder): call a rest at the table (4f2b); fix CWN's LONG… - #225
Merged
Merged
Conversation
…_REST
GET /api/sheets/rests lists the running custom system's rests that are
on (none for a built-in game). POST /api/sheets/rest calls or previews
one: { rest, players: true | [names], npcs: [token ids], preview }. The
GM and granted editors, as with the built-in rest buttons.
- sheets/rests.js: who rests (player characters in the running system,
every one or the named ones whatever their case, each with its first
token; chosen NPC tokens with the sheet linked to them in this game,
or none). A preview rolls and writes nothing. Calling one works each
sheet out inside its write queue, formulas worked out, so two rests
at once both land and a player's edit is kept; then the token's
health and conditions (a player's onto every token of theirs), one
dice-log line each, and every screen told.
- resting.js: restLine and restDice, the log line and its dice.
- runtime.js: definitionOf.
Fix: CWN's LONG_REST had written SR6's Edge (edge = edge_max) onto CWN
sheets since 821dae0 moved the resets onto the write queue, so it
recovered no strain while reporting that it had. It takes 1 System
Strain off every CWN sheet with some again, now with a test. The stray
edge values it left behind are harmless and left as they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_REST
GET /api/sheets/rests lists the running custom system's rests that are on (none for a built-in game). POST /api/sheets/rest calls or previews one: { rest, players: true | [names], npcs: [token ids], preview }. The GM and granted editors, as with the built-in rest buttons.
Fix: CWN's LONG_REST had written SR6's Edge (edge = edge_max) onto CWN sheets since 821dae0 moved the resets onto the write queue, so it recovered no strain while reporting that it had. It takes 1 System Strain off every CWN sheet with some again, now with a test. The stray edge values it left behind are harmless and left as they are.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues