Skip to content

feat(system-builder): rests as data (4f1) - #223

Merged
over2take merged 2 commits into
feature/system-builderfrom
sb/4f-rests
Oct 9, 2026
Merged

over2take merged 2 commits into
feature/system-builderfrom
sb/4f-rests

Conversation

@over2take

Copy link
Copy Markdown
Owner

Approved mockup docs/mockups/builder-rests.html (2026-10-09). A custom system's rests section: Short rest, Long rest, End of scene and End of session (renamed or turned off) plus its own, twelve in all, stored as changes only.

  • systemBuilder/rests.js: each rest counts as other rests (no loops, each one named) and refills, in order, health (to full, or up by an amount where the model heals by amounts, a track named in a two-track system), a sheet number (to its maximum, up or down by, set to) or a whole section to its maximums. Numbers worked out by a formula, linked to the token or bank, or part of the health layout are never refilled directly. restsOf gives the rests that are on, whole.
  • conditions.js: a third ending, ends: 'rest', at: [...].
  • tierRolls.js: amounts read like tier boxes, naming the character's own numbers (rollAmount); a tier still reads @Level alone.
  • definition.js: the section, checked.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

Developer added 2 commits October 9, 2026 15:51
Approved mockup docs/mockups/builder-rests.html (2026-10-09). A custom
system's `rests` section: Short rest, Long rest, End of scene and End
of session (renamed or turned off) plus its own, twelve in all, stored
as changes only.

- systemBuilder/rests.js: each rest counts as other rests (no loops,
  each one named) and refills, in order, health (to full, or up by an
  amount where the model heals by amounts, a track named in a two-track
  system), a sheet number (to its maximum, up or down by, set to) or a
  whole section to its maximums. Numbers worked out by a formula,
  linked to the token or bank, or part of the health layout are never
  refilled directly. restsOf gives the rests that are on, whole.
- conditions.js: a third ending, `ends: 'rest', at: [...]`.
- tierRolls.js: amounts read like tier boxes, naming the character's
  own numbers (rollAmount); a tier still reads @Level alone.
- definition.js: the section, checked.
Docker Hub refuses unauthenticated pulls once GitHub's shared runners exhaust its per-address limit; the proxy check failed three runs in a row on it. mirror.gcr.io serves the same official image without that limit.
@over2take
over2take merged commit 69894dd into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4f-rests branch October 9, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant