Skip to content

feat(system-builder): condition icons over tokens on the map (4e2b2) - #220

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4e2b2-map-condition-icons
Oct 9, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4e2b2-map-condition-icons

Conversation

@over2take

Copy link
Copy Markdown
Owner

From the approved builder-conditions mockup. Every token (enemy, friendly and player) draws its conditions as up to four icons above it, then +N; each icon is titled with its condition's name and +N lists the rest. Drawn for everyone, and whatever the game's token health, since a game without it may track harm in conditions alone. tokenConditions.ts mapIcons holds the four-then-+N rule.

useConditionList now shares one request per game and login across every window and token, forgets a failed request so the next asks again, and forgets them all once (at module level, before any hook re-asks) when a published system changes, so a map of many tokens asks once.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

From the approved builder-conditions mockup. Every token (enemy, friendly and
player) draws its conditions as up to four icons above it, then +N; each icon
is titled with its condition's name and +N lists the rest. Drawn for everyone,
and whatever the game's token health, since a game without it may track harm in
conditions alone. tokenConditions.ts mapIcons holds the four-then-+N rule.

useConditionList now shares one request per game and login across every window
and token, forgets a failed request so the next asks again, and forgets them all
once (at module level, before any hook re-asks) when a published system
changes, so a map of many tokens asks once.
@over2take
over2take merged commit 31404db into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4e2b2-map-condition-icons branch October 9, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant