Repository navigation
feat(system-builder): condition icons over tokens on the map (4e2b2) - #220
Merged
Merged
Conversation
From the approved builder-conditions mockup. Every token (enemy, friendly and player) draws its conditions as up to four icons above it, then +N; each icon is titled with its condition's name and +N lists the rest. Drawn for everyone, and whatever the game's token health, since a game without it may track harm in conditions alone. tokenConditions.ts mapIcons holds the four-then-+N rule. useConditionList now shares one request per game and login across every window and token, forgets a failed request so the next asks again, and forgets them all once (at module level, before any hook re-asks) when a published system changes, so a map of many tokens asks once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the approved builder-conditions mockup. Every token (enemy, friendly and player) draws its conditions as up to four icons above it, then +N; each icon is titled with its condition's name and +N lists the rest. Drawn for everyone, and whatever the game's token health, since a game without it may track harm in conditions alone. tokenConditions.ts mapIcons holds the four-then-+N rule.
useConditionList now shares one request per game and login across every window and token, forgets a failed request so the next asks again, and forgets them all once (at module level, before any hook re-asks) when a published system changes, so a map of many tokens asks once.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues