Skip to content

feat(system-builder): conditions in the HEALTH folder; BLIND and BLEE… - #219

Merged
over2take merged 2 commits into
feature/system-builderfrom
sb/4e2b1-health-conditions
Oct 9, 2026
Merged

over2take merged 2 commits into
feature/system-builderfrom
sb/4e2b1-health-conditions

Conversation

@over2take

Copy link
Copy Markdown
Owner

…D become conditions (4e2b1)

From the approved builder-conditions mockup. The HEALTH folder gets a CONDITIONS section (TokenConditions): every condition on the token as a wrapping chip with its icon and label, and what each means below. In the panel that changes health it offers + CONDITION from the running game's list and × to take one off, sending the whole list with every other condition's rounds left kept, and shows rounds left and modifiers from the socket's full answer. The panel that only watches someone else's health shows which conditions and what they mean.

useConditionList fetches the game's list (modifiers only with the GM's login) and asks again on customSystemChanged; useConditionDetail asks requestTokenConditions and uses only a full answer about its own token.

The injury map keeps the body and loses its BLIND and BLEED flags. A one-time startup move (startup/injuryConditions.js), after the per-system token health start, turns each flag into the Blinded or Bleeding condition on every token and in every game's saved values, in one transaction with a marker. Checked on a copy of a real database: five records moved, every body injury kept.

The stream overlay shows a selected token's conditions in place of the flags.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

Developer added 2 commits October 9, 2026 12:52
…D become conditions (4e2b1)

From the approved builder-conditions mockup. The HEALTH folder gets a CONDITIONS
section (TokenConditions): every condition on the token as a wrapping chip with
its icon and label, and what each means below. In the panel that changes health
it offers + CONDITION from the running game's list and × to take one off,
sending the whole list with every other condition's rounds left kept, and shows
rounds left and modifiers from the socket's full answer. The panel that only
watches someone else's health shows which conditions and what they mean.

useConditionList fetches the game's list (modifiers only with the GM's login)
and asks again on customSystemChanged; useConditionDetail asks
requestTokenConditions and uses only a full answer about its own token.

The injury map keeps the body and loses its BLIND and BLEED flags. A one-time
startup move (startup/injuryConditions.js), after the per-system token health
start, turns each flag into the Blinded or Bleeding condition on every token
and in every game's saved values, in one transaction with a marker. Checked on a
copy of a real database: five records moved, every body injury kept.

The stream overlay shows a selected token's conditions in place of the flags.
…dcast

The LUCK test read the sheet as soon as diceRollBroadcast was seen, but the
spend (patchSheet) runs alongside the broadcast, not before it, so on a busy CI
runner it sometimes read luck 2. It now polls with untilValue until the sheet
shows the spend. The whole sheet is waited on rather than the number, since
untilValue treats a falsy value as not yet and the expected LUCK is 0. Still
fails when the spend never happens (checked by mutation).
@over2take
over2take merged commit cdf3810 into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4e2b1-health-conditions branch October 9, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant