Repository navigation
feat(system-builder): conditions count down by the round (4e2a2) - #218
Merged
Merged
Conversation
Each new round of a combat, the initiative tracker counts its tokens' conditions down: every one with rounds left loses one, and those reaching none come off (tokens/conditions.js tickRound, tickCombat). A new round is when the turn order wraps, when the sides wrap in side mode, or in Shadowrun when every pass is spent rather than at the end of each pass. The combat's tokens come from the tracker's ids: npc:<id> for NPC tokens, player:<name> for every token of that player's, each counted once. Every screen redraws the map when any changed. A new socket request, requestTokenConditions, answers a token's conditions as the viewer may see them, under every system: the GM, the token's owner and a player given a friendly NPC get the rounds left and each condition's modifiers; anyone else gets which conditions, as the token list shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each new round of a combat, the initiative tracker counts its tokens' conditions down: every one with rounds left loses one, and those reaching none come off (tokens/conditions.js tickRound, tickCombat). A new round is when the turn order wraps, when the sides wrap in side mode, or in Shadowrun when every pass is spent rather than at the end of each pass. The combat's tokens come from the tracker's ids: npc: for NPC tokens, player: for every token of that player's, each counted once. Every screen redraws the map when any changed.
A new socket request, requestTokenConditions, answers a token's conditions as the viewer may see them, under every system: the GM, the token's owner and a player given a friendly NPC get the rounds left and each condition's modifiers; anyone else gets which conditions, as the token list shows.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues