Repository navigation
feat(system-builder): the builder's CONDITIONS page (4e1b) - #216
Merged
Merged
Conversation
From the approved builder-conditions mockup. A new rail page between NPCS and TRY IT: the ten standard conditions with on/off switches, the system's own below them (+ CONDITION up to 60 in all, DELETE after asking), and for the one picked its name (the standard name as placeholder), chip label, icon, description, how it ends (when removed, or after rounds; a refresh event shown as coming) and its modifiers on all rolls, a stat or a formula. Typed numbers keep a lone minus sign. Locked like every other page on a built-in example. sheets/conditions.ts mirrors the server's conditions.js and is tested against it: a standard condition stores only what differs, so putting it back leaves nothing; one of the system's own keeps its name as typed, so a blank one shows as a problem rather than vanishing. The 24 icons are drawn for CITY_NET in sheets/conditionIcons.ts as path data, stroked in currentColor and never filled. The four first sketched too close to Feather's (eye, music note, bolt, anchor) are redrawn, and a test checks none of Feather's paths appear. ConditionIcon draws an uploaded one through <img> only. uploadIcon takes 'condition' for the conditions' own upload route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the approved builder-conditions mockup. A new rail page between NPCS and TRY IT: the ten standard conditions with on/off switches, the system's own below them (+ CONDITION up to 60 in all, DELETE after asking), and for the one picked its name (the standard name as placeholder), chip label, icon, description, how it ends (when removed, or after rounds; a refresh event shown as coming) and its modifiers on all rolls, a stat or a formula. Typed numbers keep a lone minus sign. Locked like every other page on a built-in example.
sheets/conditions.ts mirrors the server's conditions.js and is tested against it: a standard condition stores only what differs, so putting it back leaves nothing; one of the system's own keeps its name as typed, so a blank one shows as a problem rather than vanishing.
The 24 icons are drawn for CITY_NET in sheets/conditionIcons.ts as path data, stroked in currentColor and never filled. The four first sketched too close to Feather's (eye, music note, bolt, anchor) are redrawn, and a test checks none of Feather's paths appear. ConditionIcon draws an uploaded one through
only. uploadIcon takes 'condition' for the conditions' own upload route.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues