Skip to content

feat(system-builder): the builder's CONDITIONS page (4e1b) - #216

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4e1b-conditions-page
Oct 9, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4e1b-conditions-page

Conversation

@over2take

Copy link
Copy Markdown
Owner

From the approved builder-conditions mockup. A new rail page between NPCS and TRY IT: the ten standard conditions with on/off switches, the system's own below them (+ CONDITION up to 60 in all, DELETE after asking), and for the one picked its name (the standard name as placeholder), chip label, icon, description, how it ends (when removed, or after rounds; a refresh event shown as coming) and its modifiers on all rolls, a stat or a formula. Typed numbers keep a lone minus sign. Locked like every other page on a built-in example.

sheets/conditions.ts mirrors the server's conditions.js and is tested against it: a standard condition stores only what differs, so putting it back leaves nothing; one of the system's own keeps its name as typed, so a blank one shows as a problem rather than vanishing.

The 24 icons are drawn for CITY_NET in sheets/conditionIcons.ts as path data, stroked in currentColor and never filled. The four first sketched too close to Feather's (eye, music note, bolt, anchor) are redrawn, and a test checks none of Feather's paths appear. ConditionIcon draws an uploaded one through only. uploadIcon takes 'condition' for the conditions' own upload route.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

From the approved builder-conditions mockup. A new rail page between NPCS and
TRY IT: the ten standard conditions with on/off switches, the system's own below
them (+ CONDITION up to 60 in all, DELETE after asking), and for the one picked
its name (the standard name as placeholder), chip label, icon, description, how
it ends (when removed, or after rounds; a refresh event shown as coming) and its
modifiers on all rolls, a stat or a formula. Typed numbers keep a lone minus
sign. Locked like every other page on a built-in example.

sheets/conditions.ts mirrors the server's conditions.js and is tested against
it: a standard condition stores only what differs, so putting it back leaves
nothing; one of the system's own keeps its name as typed, so a blank one shows
as a problem rather than vanishing.

The 24 icons are drawn for CITY_NET in sheets/conditionIcons.ts as path data,
stroked in currentColor and never filled. The four first sketched too close to
Feather's (eye, music note, bolt, anchor) are redrawn, and a test checks none
of Feather's paths appear. ConditionIcon draws an uploaded one through <img>
only. uploadIcon takes 'condition' for the conditions' own upload route.
@over2take
over2take merged commit 4b8a8cc into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4e1b-conditions-page branch October 13, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant