Repository navigation
feat(system-builder): conditions as data (4e1a) - #215
Merged
Merged
Conversation
From the approved builder-conditions mockup. A definition's `conditions` section
holds only changes: a standard condition turned off ({ on: false }) or edited,
and the system's own conditions by id. Ten standard ones every system starts
with: Blinded, Bleeding, Poisoned, Prone, Stunned, Grappled, Frightened,
Unconscious, Restrained, Exhausted. Up to 60 in all.
Each has a name, a chip label, an icon (one of 24 drawn for CITY_NET, or an
uploaded PNG/WebP/SVG under /uploads/condition_icons), a description, how it
ends (when removed, or after 1 to 99 rounds) and up to 10 modifiers on a stat,
a formula or all rolls. Modifiers are recorded; they reach rolls with Phase 6.
checkConditions reports every problem with where it is; conditionsOf gives the
running game and the builder each condition whole, in order. The currency icon
upload route becomes a shared helper, and POST /api/systems/condition-icons
uses it, main admin only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the approved builder-conditions mockup. A definition's
conditionssection holds only changes: a standard condition turned off ({ on: false }) or edited, and the system's own conditions by id. Ten standard ones every system starts with: Blinded, Bleeding, Poisoned, Prone, Stunned, Grappled, Frightened, Unconscious, Restrained, Exhausted. Up to 60 in all.Each has a name, a chip label, an icon (one of 24 drawn for CITY_NET, or an uploaded PNG/WebP/SVG under /uploads/condition_icons), a description, how it ends (when removed, or after 1 to 99 rounds) and up to 10 modifiers on a stat, a formula or all rolls. Modifiers are recorded; they reach rolls with Phase 6.
checkConditions reports every problem with where it is; conditionsOf gives the running game and the builder each condition whole, in order. The currency icon upload route becomes a shared helper, and POST /api/systems/condition-icons uses it, main admin only.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues