Repository navigation
feat(system-builder): genre starters in + NEW, and the README held to… - #214
Merged
Merged
Conversation
… the code (4d3b) A GENRE STARTER is turned on in + NEW: the same cards, COPY and LOOK FIRST as the built-in examples, listed with ?kind=starter. Switching between games and starters starts the pick afresh. GET /api/systems/examples/:id now says which kind it is, so the builder marks a starter looked at as STARTER · READ ONLY under A GENRE STARTER. README.md's Project Structure caught up, at the user's request: 202 source and test files had no line and 28 lines put a file in the wrong folder (24 sheet helpers drawn under src/ rather than src/sheets/, among others). Every file is now described in its folder, and stale lines are corrected (systemBuilder/ no longer "not used by the app", definitions.js, definition.js, npc.js, routes/systems.js, the parity test). backend/__tests__/readme_structure.test.js keeps it that way: it reads the tree by indentation into full paths and fails on any backend or frontend/src source or test file it doesn't name, or any line naming a file that has gone, listing each. Its comparisons are tested on a sample tree so they can fail even while the real tree is complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the code (4d3b)
A GENRE STARTER is turned on in + NEW: the same cards, COPY and LOOK FIRST as the built-in examples, listed with ?kind=starter. Switching between games and starters starts the pick afresh. GET /api/systems/examples/:id now says which kind it is, so the builder marks a starter looked at as STARTER · READ ONLY under A GENRE STARTER.
README.md's Project Structure caught up, at the user's request: 202 source and test files had no line and 28 lines put a file in the wrong folder (24 sheet helpers drawn under src/ rather than src/sheets/, among others). Every file is now described in its folder, and stale lines are corrected (systemBuilder/ no longer "not used by the app", definitions.js, definition.js, npc.js, routes/systems.js, the parity test).
backend/tests/readme_structure.test.js keeps it that way: it reads the tree by indentation into full paths and fails on any backend or frontend/src source or test file it doesn't name, or any line naming a file that has gone, listing each. Its comparisons are tested on a sample tree so they can fail even while the real tree is complete.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues