Skip to content

feat(system-builder): genre starters in + NEW, and the README held to… - #214

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/4d3b-starters-ui-readme
Oct 9, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/4d3b-starters-ui-readme

Conversation

@over2take

Copy link
Copy Markdown
Owner

… the code (4d3b)

A GENRE STARTER is turned on in + NEW: the same cards, COPY and LOOK FIRST as the built-in examples, listed with ?kind=starter. Switching between games and starters starts the pick afresh. GET /api/systems/examples/:id now says which kind it is, so the builder marks a starter looked at as STARTER · READ ONLY under A GENRE STARTER.

README.md's Project Structure caught up, at the user's request: 202 source and test files had no line and 28 lines put a file in the wrong folder (24 sheet helpers drawn under src/ rather than src/sheets/, among others). Every file is now described in its folder, and stale lines are corrected (systemBuilder/ no longer "not used by the app", definitions.js, definition.js, npc.js, routes/systems.js, the parity test).

backend/tests/readme_structure.test.js keeps it that way: it reads the tree by indentation into full paths and fails on any backend or frontend/src source or test file it doesn't name, or any line naming a file that has gone, listing each. Its comparisons are tested on a sample tree so they can fail even while the real tree is complete.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

… the code (4d3b)

A GENRE STARTER is turned on in + NEW: the same cards, COPY and LOOK FIRST as
the built-in examples, listed with ?kind=starter. Switching between games and
starters starts the pick afresh. GET /api/systems/examples/:id now says which
kind it is, so the builder marks a starter looked at as STARTER · READ ONLY
under A GENRE STARTER.

README.md's Project Structure caught up, at the user's request: 202 source and
test files had no line and 28 lines put a file in the wrong folder (24 sheet
helpers drawn under src/ rather than src/sheets/, among others). Every file is
now described in its folder, and stale lines are corrected (systemBuilder/ no
longer "not used by the app", definitions.js, definition.js, npc.js,
routes/systems.js, the parity test).

backend/__tests__/readme_structure.test.js keeps it that way: it reads the tree
by indentation into full paths and fails on any backend or frontend/src source
or test file it doesn't name, or any line naming a file that has gone, listing
each. Its comparisons are tested on a sample tree so they can fail even while
the real tree is complete.
@over2take
over2take merged commit f931fab into feature/system-builder Oct 9, 2026
4 checks passed
@over2take
over2take deleted the sb/4d3b-starters-ui-readme branch October 13, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant