Repository navigation
feat(system-builder): Cyberpunk RED and Generic as data (4d2) - #212
Merged
Merged
Conversation
CYBERPUNK_RED (emp = floor(@humanity / 10)) and GENERIC (nothing) join definitions.js, each held to the games' own applyDerived over 3000 generated sheets in the parity test. CP:R's code is a trigger on Humanity being written; the engine recomputes on every write. They agree on EMP whenever Humanity is written as a number. The three differences are pinned as tests: a hand-typed EMP survives other writes only in the code; Humanity that isn't a number leaves EMP alone in the code but makes it 0 in the engine; the code rewrites and reports EMP even when it already read right. Cyberpunk RED is added to the builder's examples: ten stats plus Humanity, eurodollars and Improvement Points, and the NPC generator's four tiers as plain numbers. Generic gets no example, since a copy would be BLANK. The + NEW card's advancement line now uses the system's XP word in the plural. The built-in games are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CYBERPUNK_RED (emp = floor(@humanity / 10)) and GENERIC (nothing) join definitions.js, each held to the games' own applyDerived over 3000 generated sheets in the parity test.
CP:R's code is a trigger on Humanity being written; the engine recomputes on every write. They agree on EMP whenever Humanity is written as a number. The three differences are pinned as tests: a hand-typed EMP survives other writes only in the code; Humanity that isn't a number leaves EMP alone in the code but makes it 0 in the engine; the code rewrites and reports EMP even when it already read right.
Cyberpunk RED is added to the builder's examples: ten stats plus Humanity, eurodollars and Improvement Points, and the NPC generator's four tiers as plain numbers. Generic gets no example, since a copy would be BLANK. The + NEW card's advancement line now uses the system's XP word in the plural. The built-in games are unchanged.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues