Repository navigation
Drop classgraph test dependency - #932
Merged
Merged
Conversation
ClassGraph 6 requires Java 25 (class file version 69) while the project targets Java 17. Replace its single use in ClassAnnotationsTest with a plain JDK scan of the compiled classes. Supersedes oras-project#931 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
============================================
+ Coverage 87.19% 87.60% +0.41%
Complexity 1284 1284
============================================
Files 51 51
Lines 4131 4131
Branches 569 569
============================================
+ Hits 3602 3619 +17
+ Misses 309 292 -17
Partials 220 220 ☔ View full report in Codecov by Harness. |
jonesbusy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassGraph 6.0.0 (#931) is compiled for Java 25 (class file version 69) and fails to compile on Java 17:
ClassGraph was only used in
ClassAnnotationsTestto find@OrasModelclasses. This replaces it with a small JDK-only scan of the compiled classes directory (Files.walk+Class.forName), and removes the dependency from the pom. The assertions (43 / 10 / 11 classes) are unchanged and pass.Supersedes #931 (Renovate will close it once the dependency is gone).
🤖 Generated with Claude Code