Repository navigation
[AI-FSSDK] [FSSDK-12958] Continue rule evaluation after local holdout hit - #1181
Merged
Alex Yong (alexjoeyyong) merged 3 commits intoOct 29, 2026
Conversation
|
coverage: 77.513% (-0.04%) from 77.554% — ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix into master |
Alex Yong (alexjoeyyong)
requested review from
esrakartalOpt and
Raju Ahmed (raju-opti)
and removed request for
Raju Ahmed (raju-opti)
October 27, 2026 18:35
Raju Ahmed (raju-opti)
force-pushed
the
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
branch
from
October 28, 2026 15:42
86d24f1 to
a291452
Compare
Raju Ahmed (raju-opti)
approved these changes
Oct 28, 2026
Raju Ahmed (raju-opti)
left a comment
Raju Ahmed (raju-opti)
left a comment
Contributor
There was a problem hiding this comment.
Looks good. a couple of non-blocking comments
…gacy holdout events
Alex Yong (alexjoeyyong)
deleted the
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
branch
October 29, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A local holdout hit used to return the holdout variation right away and skip every remaining rule for the flag. Now a hit only excludes the user from that one rule, and evaluation moves on to the next experiment or delivery rule. Each hit still sends its own holdout impression.
Changes
Jira Ticket
FSSDK-12958