Skip to content

🌱 build: migrate Bingo tooling to Go module tools - #3092

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:build/migrate-bingo-tools-to-go-tool
Nov 3, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:build/migrate-bingo-tools-to-go-tool

Conversation

@tmshort

@tmshort tmshort commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Replace Bingo-managed tool binaries with Go tool directives and go tool invocations, using versions pinned in go.mod.
  • Move kube-score into the root module at the version merged in 🌱 build: update Bingo kube-score to upstream master #3087; it builds with the project's Kubernetes v0.37.1 dependencies.
  • Keep opm and operator-sdk on tagged go build commands because they require containers_image_openpgp, which go tool does not accept.
  • Remove the root .bingo directory and update generation, lint, and Tilt integration.

Validation

  • make verify
  • make lint (0 issues)
  • go mod verify
  • go tool kube-score version

The downstream root-Bingo reference is being moved to openshift/.bingo in openshift/operator-framework-operator-controller#842.

Summary by CodeRabbit

  • Chores
    • Migrated development tools to Go tool directives and module-based version pinning.
    • Updated build, test, code-generation, linting, and release workflows to use the revised tool commands.
    • Pull-request checks now run when Go module files change.
    • Removed the previous tool-management files and documentation; related setup instructions have been updated.

@openshift-ci
openshift-ci Bot requested review from dtfranz and joelanford November 2, 2026 14:39
@netlify

netlify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c6d6217
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6aea148aab67502b46d9e8c2
😎 Deploy Preview https://deploy-preview-3092--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 15
  • .bingo/bingo.sum is excluded by !**/*.sum
  • .bingo/conftest.sum is excluded by !**/*.sum
  • .bingo/crd-diff.sum is excluded by !**/*.sum
  • .bingo/crd-ref-docs.sum is excluded by !**/*.sum
  • .bingo/golangci-lint.sum is excluded by !**/*.sum
  • .bingo/goreleaser.sum is excluded by !**/*.sum
  • .bingo/helm.sum is excluded by !**/*.sum
  • .bingo/kind.sum is excluded by !**/*.sum
  • .bingo/kube-score.sum is excluded by !**/*.sum
  • .bingo/mockgen.sum is excluded by !**/*.sum
  • .bingo/operator-sdk.sum is excluded by !**/*.sum
  • .bingo/opm.sum is excluded by !**/*.sum
  • .bingo/setup-envtest.sum is excluded by !**/*.sum
  • .bingo/yamlfmt.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 9bdd4513-9c72-4151-acd4-71f4ac929d49
Commits

Reviewing files that changed from the base of the PR and between 52594ec and c6d6217.

Files ignored due to path filters: 15
  • .bingo/bingo.sum is excluded by !**/*.sum
  • .bingo/conftest.sum is excluded by !**/*.sum
  • .bingo/crd-diff.sum is excluded by !**/*.sum
  • .bingo/crd-ref-docs.sum is excluded by !**/*.sum
  • .bingo/golangci-lint.sum is excluded by !**/*.sum
  • .bingo/goreleaser.sum is excluded by !**/*.sum
  • .bingo/helm.sum is excluded by !**/*.sum
  • .bingo/kind.sum is excluded by !**/*.sum
  • .bingo/kube-score.sum is excluded by !**/*.sum
  • .bingo/mockgen.sum is excluded by !**/*.sum
  • .bingo/operator-sdk.sum is excluded by !**/*.sum
  • .bingo/opm.sum is excluded by !**/*.sum
  • .bingo/setup-envtest.sum is excluded by !**/*.sum
  • .bingo/yamlfmt.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

Tool dependencies move into the root Go module, and bingo-managed files are removed. Make targets, CI configuration, lint lookup, mock-generation directives, and tool guidance are updated to use Go tool commands.

Changes: Go Tool Management

Layer / File(s) Summary
Move tool declarations to Go modules
go.mod, .bingo/*, AGENTS.md
go.mod gains tool dependencies and directives. Bingo-managed files are deleted, and the tools guidance is updated.
Update Makefile and CI tool use
Makefile, .github/workflows/tilt.yaml
Make targets and the Tilt workflow use Go tool lookups and drop bingo-based tool prerequisites. The CI path filter now includes go.mod and go.sum.
Update lint and mock-generation commands
hack/api-lint-diff/run.sh, internal/object-controller/controllers/clusterobjectset_controller.go, internal/testutil/mock/generate.go
The API lint script looks up golangci-lint through Go tools and the root module. Mock-generation directives invoke mockgen through go tool.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Suggested reviewers: rashmigottipati

Merge Risk: Minimal · previous review 52594

The tool migration has no confirmed merge-blocking regressions.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: migrating Bingo-managed tooling to Go module tools. It is concise and uses the required seedling prefix.
Description check Passed The description clearly explains the migration, key exceptions, removed directory, affected integrations, validation performed, and related pull request. It does not use the exact template headings or…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the migration, key exceptions, removed directory, affected integrations, validation performed, and related pull request. It does not use the exact template headings or include the reviewer checklist, but it provides the required substantive information.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 685a126d-f92b-4874-b22f-7aa8d3a30f70
Commits

Reviewing files that changed from the base of the PR and between e93ace4 and 52594ec.

Files ignored due to path filters: 15
  • .bingo/bingo.sum is excluded by !**/*.sum
  • .bingo/conftest.sum is excluded by !**/*.sum
  • .bingo/crd-diff.sum is excluded by !**/*.sum
  • .bingo/crd-ref-docs.sum is excluded by !**/*.sum
  • .bingo/golangci-lint.sum is excluded by !**/*.sum
  • .bingo/goreleaser.sum is excluded by !**/*.sum
  • .bingo/helm.sum is excluded by !**/*.sum
  • .bingo/kind.sum is excluded by !**/*.sum
  • .bingo/kube-score.sum is excluded by !**/*.sum
  • .bingo/mockgen.sum is excluded by !**/*.sum
  • .bingo/operator-sdk.sum is excluded by !**/*.sum
  • .bingo/opm.sum is excluded by !**/*.sum
  • .bingo/setup-envtest.sum is excluded by !**/*.sum
  • .bingo/yamlfmt.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
Files selected for processing: 2
  • AGENTS.md
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2026

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread AGENTS.md Resolved
Comment thread go.mod Resolved
@tmshort tmshort changed the title build: migrate Bingo tooling to Go module tools 🌱 build: migrate Bingo tooling to Go module tools Nov 2, 2026
@tmshort
tmshort force-pushed the build/migrate-bingo-tools-to-go-tool branch from e93ace4 to 52594ec Compare November 2, 2026 16:53
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2026
@perdasilva

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2026
Pin tools in go.mod and invoke them through go tool, including kube-score with Kubernetes API v0.37.1. Keep opm at v1.74.0 and build it and operator-sdk with the required containers_image_openpgp tag. Remove Bingo and update generation, lint, and Tilt integration.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort force-pushed the build/migrate-bingo-tools-to-go-tool branch from 52594ec to c6d6217 Compare November 3, 2026 17:06
@tmshort

tmshort commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Rebasing ought to fix the go-apidiff job.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2026
@openshift-ci

openshift-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 0e263f8 into operator-framework:main Nov 3, 2026
30 checks passed
@tmshort
tmshort deleted the build/migrate-bingo-tools-to-go-tool branch November 3, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants