Repository navigation
Conversation
drgrice1
force-pushed
the
validate-email-address-when-set
branch
from
October 16, 2026 17:38
75c6c3d to
07ccd41
Compare
Member
|
This looks like it is detecting bad emails everywhere they can be entered. I was testing in the Add users section of the Accounts Manager and putting it a bad email address gives the message but clears all of the input. I realize this is a the same behavior as before but could we instead keep the previous input in each box and perhaps put a red outline around the email box--this could be done for the login name as well. |
drgrice1
force-pushed
the
validate-email-address-when-set
branch
from
October 20, 2026 19:25
07ccd41 to
7625d8a
Compare
Add an `isValidEmailAddress` method to `WeBWorK::Utils` that uses Email::Address::XS to check that an email address is valid, and use it wherever a user's email address is set (other than from an LMS via LTI). * Account Settings page: An invalid new address is rejected with a message. * Classlist editor: An invalid address is rejected with a message and the user's address is left unchanged. An empty address is still allowed. * Classlist import (both from the classlist editor and the `importClassList.pl` and `addcourse` scripts): An invalid address is replaced with an empty address and the user is still imported, and the affected users are reported. * Add Users page: A user with an invalid address is not added and the reason is shown in the report. * Course Administration add course form: An invalid address for an additional user is a validation error. * Course actions API addUser method: Adding a new user with an invalid address returns an error. * Feedback page: The sender's address is validated with the same method instead of a custom regular expression. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
drgrice1
force-pushed
the
validate-email-address-when-set
branch
from
October 20, 2026 21:37
7625d8a to
45e29aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
isValidEmailAddressmethod toWeBWorK::Utilsthat uses Email::Address::XS to check that an email address is valid, and use it wherever a user's email address is set (other than from an LMS via LTI).importClassList.plandaddcoursescripts): An invalid address is replaced with an empty address and the user is still imported, and the affected users are reported.