Skip to content

[kuttl] Drop null Job pod template creationTimestamp asserts (18.0-fr6) - #2083

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:18.0-fr6from
nemarjan:fix-kuttl-creationtimestamp-18.0-fr6
Sep 16, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:18.0-fr6from
nemarjan:fix-kuttl-creationtimestamp-18.0-fr6

Conversation

@nemarjan

Copy link
Copy Markdown
Contributor

Cherry-pick of #2052 to 18.0-fr6.

OCP 4.22 no longer serializes creationTimestamp: null in Job pod template
metadata (omitempty). The kuttl assertions still expect that field, causing
dataplane-deploy-global-service-test to fail with:

.spec.template.metadata.creationTimestamp: key is missing from map

Remove the dumped null fields from the Job asserts so the test does not
depend on that serialization difference.

Signed-off-by: nemarjan nemarjan@redhat.com

Made with Cursor

cifmw-multinode-kuttl started failing after GitHub check jobs moved from
OCP 4.20 to 4.22. Dataplane deploy succeeds; KUTTL then compares live
Jobs against a YAML dump that still has
Job.spec.template.metadata.creationTimestamp: null.

On 4.20 the API still serialized that null key. On 4.22 Kubernetes omits
empty creationTimestamp (omitempty), so KUTTL waits the full timeout and
fails with:

  .spec.template.metadata.creationTimestamp: key is missing from map

Remove the dumped null fields from all remaining dataplane Job asserts
so the tests do not depend on that serialization difference.

Signed-off-by: Nemanja Marjanovic <nemarjan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 17b15a52-4598-43f7-8522-473c9eae5ece

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from slagle and stuggi September 16, 2026 12:46
@github-actions

Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 349969 bytes (342KB)
Base branch size 349969 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@nemarjan nemarjan self-assigned this Sep 16, 2026

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nemarjan, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app

Copy link
Copy Markdown

@openshift-merge-bot
openshift-merge-bot Bot merged commit d440d81 into openstack-k8s-operators:18.0-fr6 Sep 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants