Repository navigation
Add default('') to discovered image vars - #3799
openshift-merge-bot[bot] merged 1 commit into
Conversation
|
My deployment fails without this patch when I use the following ansible: |
e5dc773 to
e1d015e
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4eef9e51d577495f8c7e676d45ac837e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 04s |
cifmw_discovered_image_url and cifmw_discovered_hash are set
dynamically by the discover_latest_image role. When networking_mapper
serializes hostvars early in the play, these variables are not yet
defined, causing a fatal undefined variable error. Add | default('')
so serialization succeeds; the real values are populated later when
discover_latest_image runs.
Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: John Fulton <fulton@redhat.com>
e1d015e to
2b92105
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ee78a6df760b438eb4c9869b1cfbb895 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 30s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ff13b2f73827423b8f1c0fef81073028 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 23s |
|
recheck |
michburk
left a comment
There was a problem hiding this comment.
I understand the motivation for the changes and they lgtm, but is there a reason to only apply these changes to va-hci.yml? If this is an issue for other scenarios, we should consider a more widespread fix.
|
recheck |
|
This PR is stale because it has been for over 15 days with no activity. |
I was trying to reproduce I didn't try to fix it for other scenarios because I was not testing them. |
Created: https://redhat.atlassian.net/browse/OSPCIFMW-105 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evallesp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cb17c52
into
openstack-k8s-operators:main
cifmw_discovered_image_urlandcifmw_discovered_hashare set dynamically by thediscover_latest_imagerole. Whennetworking_mapperserializes hostvars early in the play, these variables are not yet defined, causing a fatal undefined variable error. Add| default('')so serialization succeeds; the real values are populated later whendiscover_latest_imageruns.Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com