OCPBUGS-112658: [5.0] enable DRADeviceTaintRules feature gate in TPNU/DevPreview by haircommander · Pull Request #3094 · openshift/api

haircommander · 2026-10-12T18:43:44Z

cherry-pick of #3072

openshift-merge-bot · 2026-10-12T18:43:46Z

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

openshift-ci-robot · 2026-10-12T18:43:50Z

@haircommander: This pull request references Jira Issue OCPBUGS-112658, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-123649 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-123649 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-pick of #3072

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-10-12T18:43:53Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: da8d4af2-ce3f-4a5c-bc18-6006fc9b6502

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-10-12T18:43:55Z

Hello @haircommander! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

Signed-off-by: Peter Hunt <pehunt@redhat.com>

haircommander · 2026-10-12T22:46:58Z

/pipeline required

openshift-merge-bot · 2026-10-12T22:47:12Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

haircommander · 2026-10-13T13:04:52Z

/retest

haircommander · 2026-10-13T18:18:05Z

/retest

haircommander · 2026-10-13T23:24:16Z

/retest

haircommander · 2026-10-14T19:51:11Z

/verified by @haircommander
manually tested and verified the v1beta2 apis are enabled when tpnu is enabled
also the new test passes in https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/openshift_api/3094/pull-ci-openshift-api-release-5.0-e2e-aws-ovn-techpreview/2109778011564806144

openshift-ci-robot · 2026-10-14T19:51:28Z

@haircommander: This PR has been marked as verified by @haircommander.

Details

In response to this:

/verified by @haircommander
manually tested and verified the v1beta2 apis are enabled when tpnu is enabled
also the new test passes in https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/openshift_api/3094/pull-ci-openshift-api-release-5.0-e2e-aws-ovn-techpreview/2109778011564806144

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

haircommander · 2026-10-14T19:51:59Z

@harche @JoelSpeed PTAL
(hypershift job should fix when openshift/hypershift#9914 merges)

harche

The change matches #3072 exactly, and the verify-payload-crds.sh fix matches master. I checked the e2e-aws-ovn-hypershift failure: the scheduler can't list v1beta2.DeviceTaintRule because the hosted cluster's kube-apiserver doesn't turn on resource.k8s.io/v1beta2. That's what openshift/hypershift#9914 fixes, so it needs to merge first, same order as on master (openshift/hypershift#9518, then #3072). Once it merges, let's /test e2e-aws-ovn-hypershift here and drop the hold when it passes.

/lgtm
/hold

openshift-merge-bot · 2026-10-14T20:12:04Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

haircommander · 2026-10-14T22:14:52Z

/retest

haircommander · 2026-10-14T23:07:11Z

/test e2e-aws-ovn-hypershift

haircommander · 2026-10-15T03:13:20Z

/retest

openshift-ci · 2026-10-15T06:49:29Z

@haircommander: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

JoelSpeed · 2026-10-15T07:53:07Z

/lgtm
/label backport-risk-assessed

openshift-ci · 2026-10-15T07:55:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2026-10-15T12:35:45Z

/unhold

openshift-ci-robot · 2026-10-15T12:40:54Z

@haircommander: Jira Issue OCPBUGS-112658: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-112658 has been moved to the MODIFIED state.

Details

In response to this:

cherry-pick of #3072

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-10-16T05:25:12Z

Fix included in release 5.0.0-0.nightly-2026-10-15-220539

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 12, 2026

openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2026

openshift-ci Bot requested review from JoelSpeed and everettraven October 12, 2026 18:44

haircommander force-pushed the device-taint-release-5.0 branch from 25bc7bc to 589a3f2 Compare October 12, 2026 18:44

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2026

haircommander force-pushed the device-taint-release-5.0 branch from 589a3f2 to 39933e6 Compare October 12, 2026 20:01

openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2026

openshift-ci-robot mentioned this pull request Oct 12, 2026

[release-5.0] OCPBUGS-112658: allow v1beta2 DRA API in discovery test openshift/origin#31728

Merged

haircommander added 2 commits October 12, 2026 17:09

enable DRADeviceTaintRules feature gate in TPNU/DevPreview

8f2b705

Signed-off-by: Peter Hunt <pehunt@redhat.com>

fix payload CRD verification with pipefail

cac9e1a

haircommander force-pushed the device-taint-release-5.0 branch from 39933e6 to cac9e1a Compare October 12, 2026 21:14

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 14, 2026

harche reviewed Oct 14, 2026

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2026

openshift-ci Bot assigned harche Oct 14, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 15, 2026

openshift-ci Bot assigned gangwgr and JoelSpeed Oct 15, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2026

openshift-merge-bot Bot merged commit 7058620 into openshift:release-5.0 Oct 15, 2026
27 checks passed

Conversation

haircommander commented Oct 12, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 12, 2026

Uh oh!

openshift-ci-robot commented Oct 12, 2026

Uh oh!

coderabbitai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Oct 12, 2026

Uh oh!

haircommander commented Oct 12, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 12, 2026

Uh oh!

haircommander commented Oct 13, 2026

Uh oh!

haircommander commented Oct 13, 2026

Uh oh!

haircommander commented Oct 13, 2026

Uh oh!

haircommander commented Oct 14, 2026

Uh oh!

openshift-ci-robot commented Oct 14, 2026

Uh oh!

haircommander commented Oct 14, 2026

Uh oh!

harche left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Oct 14, 2026

Uh oh!

haircommander commented Oct 14, 2026

Uh oh!

haircommander commented Oct 14, 2026

Uh oh!

haircommander commented Oct 15, 2026

Uh oh!

openshift-ci Bot commented Oct 15, 2026

Uh oh!

JoelSpeed commented Oct 15, 2026

Uh oh!

openshift-ci Bot commented Oct 15, 2026

Uh oh!

haircommander commented Oct 15, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 15, 2026

Uh oh!

openshift-merge-robot commented Oct 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading