Skip to content

Bump SMTP and IMAP block dependencies to fix vulnerabilities - #2512

Merged
ravikiranvm merged 2 commits into
mainfrom
ops-4836
Sep 17, 2026
Merged

ravikiranvm merged 2 commits into
mainfrom
ops-4836

Conversation

@ravikiranvm

@ravikiranvm ravikiranvm commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Fixes OPS-4836.

Bump imapflow, mailparser and nodemailer to fix Snyk high-severity findings in transitive nodemailer versions.

Additional Notes

  • send-email.ts: nodemailer 10 ships its own type declarations and no longer exports Attachment and Headers as named types from nodemailer/lib/mailer. Import Attachment and Mail from the nodemailer root instead and use Mail.Headers. @types/nodemailer removed as redundant.
  • connection-error-handler.ts: add an explicit EAUTH case. A wrong password now returns "Check the username and password." instead of the generic code-only message. Test added.

Testing Checklist

  • I tested the feature thoroughly, including edge cases
  • I verified all affected areas still work as expected
  • Automated tests were added/updated if necessary
  • Changes are backwards compatible with any existing data, otherwise a migration script is provided

Manual tests against Gmail:

  • SMTP Send Email with HTML body, custom header and URL attachment → delivered.
  • IMAP New Email trigger → mailbox list populated, message fetched and parsed with header and attachment.
  • SMTP with wrong app password → fast, readable EAUTH error.

@linear

linear Bot commented Sep 17, 2026

Copy link
Copy Markdown

OPS-4836

@ravikiranvm ravikiranvm changed the title Bump SMTP and IMAP block dependancies to fix vulerabilities Bump SMTP and IMAP block dependencies to fix vulnerabilities Sep 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@ravikiranvm
ravikiranvm marked this pull request as ready for review September 17, 2026 09:40
Copilot AI lite review requested due to automatic review settings September 17, 2026 09:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Align the EAUTH message with the behavior stated in the pull request description.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates SMTP/IMAP dependencies to address Nodemailer vulnerabilities and adapt SMTP code for Nodemailer 10.

Changes:

  • Bumps imapflow, mailparser, and nodemailer.
  • Updates Nodemailer type imports and adds EAUTH handling.
  • Refreshes lockfile and license metadata.
File summaries
File Description
THIRD_PARTY_LICENSES.txt Refreshes dependency license metadata.
packages/blocks/smtp/test/connection-error-handler.test.ts Adds EAUTH handling coverage.
packages/blocks/smtp/src/lib/connection-error-handler.ts Adds explicit EAUTH handling.
packages/blocks/smtp/src/lib/actions/send-email.ts Updates Nodemailer 10 type imports.
package.json Updates dependencies and removes redundant Nodemailer types.
package-lock.json Locks updated dependency versions.
Review details
  • Files reviewed: 5/6 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/blocks/smtp/src/lib/connection-error-handler.ts
@ravikiranvm
ravikiranvm merged commit 9187117 into main Sep 17, 2026
24 checks passed
@ravikiranvm
ravikiranvm deleted the ops-4836 branch September 17, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants