Skip to content

Update of-watchdog to 0.12.4 - #81

Merged
alexellis merged 1 commit into
masterfrom
of-watchdog-0.12.4
Oct 8, 2026
Merged

alexellis merged 1 commit into
masterfrom
of-watchdog-0.12.4

Conversation

@alexellis

Copy link
Copy Markdown
Member

What

  • update of-watchdog from 0.12.3 to 0.12.4 in all five Python templates

Why

of-watchdog 0.12.4 adopts the corrected OAuth session claim contract from faas-middleware v1.2.10. This is corrective and consistency work for a feature that has not yet been adopted by users.

Validation

  • bash verify.sh
  • all five Python templates built and responded successfully

Adopt the corrected OAuth session claim contract in newly built
functions and keep the official templates on the current watchdog.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis
alexellis merged commit ff7c2c5 into master Oct 8, 2026
2 checks passed
@reviewfn

reviewfn Bot commented Oct 8, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Updates ghcr.io/openfaas/of-watchdog from 0.12.3 to 0.12.4 across the five scoped Python template Dockerfiles.
  • The change is limited to the watchdog image tag used as the source stage for /fwatchdog.
  • Existing platform selection, Python base images, user setup, healthchecks, and runtime environment variables are unchanged.
  • Repository-wide Dockerfile inspection found no remaining of-watchdog:0.12.3 references.
  • The single new commit does not include a prohibited AI attribution trailer such as Co-Authored-By naming an AI or Amp-Thread-ID.
  • No blocking findings were identified from static inspection of the scoped diff.

Approval rating (1-10)

9/10. Small, consistent dependency update with no evident regression in the scoped Dockerfile changes.

Summary per file

Summary per file
File path Summary
template/python27-flask/Dockerfile Updates watchdog stage image to 0.12.4.
template/python3-flask-debian/Dockerfile Updates watchdog stage image to 0.12.4.
template/python3-flask/Dockerfile Updates watchdog stage image to 0.12.4.
template/python3-http-debian/Dockerfile Updates watchdog stage image to 0.12.4.
template/python3-http/Dockerfile Updates watchdog stage image to 0.12.4.

Overall Assessment

The pull request is narrowly scoped and applies the same watchdog image tag update consistently across the affected Python templates. The Dockerfile stage names and COPY --from=watchdog /fwatchdog /usr/bin/fwatchdog usage remain intact, so newly built functions should continue to consume the watchdog binary in the same way while picking up version 0.12.4. I did not find a concrete correctness, migration, security, or consistency issue in the scoped changes.

Detailed Review

Detailed Review

No blocking findings.

The scoped diff only changes the ghcr.io/openfaas/of-watchdog tag from 0.12.3 to 0.12.4 in each affected Dockerfile. The surrounding Dockerfile instructions continue to copy /fwatchdog from the watchdog stage into /usr/bin/fwatchdog, preserve executable permissions, and keep the existing HTTP-mode environment configuration.

The multi-platform Dockerfiles retain their existing --platform=${TARGETPLATFORM:-linux/amd64} selectors for the watchdog stage, and the Python 2.7 template preserves its previous unqualified watchdog stage form. There is no scoped change suggesting a mismatch between build platform handling and the copied watchdog binary.

The commit metadata was checked for the PR's AI-attribution policy. The single commit includes a standard sign-off and no prohibited AI authorship or assistant-attribution trailer.

AI agent details.

Agent processing time: 50.439s
Environment preparation time: 5.018s
Total time from webhook: 58.242s

@alexellis
alexellis deleted the of-watchdog-0.12.4 branch October 8, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant