Repository navigation
Add constant generation for entity types - #593
Merged
jack-berg merged 1 commit intoOct 16, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Generation and coverage are consistent, with only a non-blocking upstream Javadoc typo remaining.
1 open finding
What changed in this PR
Adds incubating Java constants for OpenTelemetry entity types using Weaver generation.
Changes:
- Adds entity-generation configuration and template.
- Generates 24 namespace-specific entity classes.
- Tests class availability, values, stability, and deprecation.
| File | Description |
|---|---|
buildscripts/templates/registry/incubating_java/weaver.yaml |
Wires entity generation. |
buildscripts/templates/registry/incubating_java/IncubatingSemanticEntities.java.j2 |
Defines entity constant generation. |
semconv-incubating/src/test/java/io/opentelemetry/semconv/incubating/IncubatingEntitiesTest.java |
Tests representative constants. |
semconv-incubating/src/test/java/io/opentelemetry/semconv/incubating/IncubatingAvailabilityTest.java |
Verifies generated classes. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/AndroidIncubatingEntities.java |
Adds Android entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/AppIncubatingEntities.java |
Adds application entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/AwsIncubatingEntities.java |
Adds AWS entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/BrowserIncubatingEntities.java |
Adds browser entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/CicdIncubatingEntities.java |
Adds CI/CD entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/CloudIncubatingEntities.java |
Adds cloud entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/CloudfoundryIncubatingEntities.java |
Adds Cloud Foundry entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/ContainerIncubatingEntities.java |
Adds container entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/DeploymentIncubatingEntities.java |
Adds deployment entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/DeviceIncubatingEntities.java |
Adds device entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/FaasIncubatingEntities.java |
Adds FaaS entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/GcpIncubatingEntities.java |
Adds GCP entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/HerokuIncubatingEntities.java |
Adds Heroku entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/HostIncubatingEntities.java |
Adds host entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/K8sIncubatingEntities.java |
Adds Kubernetes entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/OpenshiftIncubatingEntities.java |
Adds OpenShift entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/OsIncubatingEntities.java |
Adds operating-system entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/OtelIncubatingEntities.java |
Adds deprecated OTel entity constant. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/ProcessIncubatingEntities.java |
Adds process entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/ServiceIncubatingEntities.java |
Adds service entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/TelemetryIncubatingEntities.java |
Adds telemetry entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/VcsIncubatingEntities.java |
Adds VCS entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/WebengineIncubatingEntities.java |
Adds web-engine entity constants. |
semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/ZosIncubatingEntities.java |
Adds z/OS entity constants. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
breedx-splk
approved these changes
Oct 15, 2026
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
A great start, thanks!
trask
reviewed
Oct 15, 2026
| public static final String AWS_EKS_TYPE = "aws.eks"; | ||
|
|
||
| /** Entities specific to Amazon Web Services. */ | ||
| public static final String AWS_LOG_TYPE = "aws.log"; |
Member
There was a problem hiding this comment.
Some schema-v2 migration PRs are in flight which (under a one-time exception) remove or rename entities without retaining deprecated definitions:
- v2: Remove device entity in favor of a public attribute group semantic-conventions#4166
- v2: Remove Android entity in favor of a public attribute group semantic-conventions#4168
- v2: Remove aws.eks, cloud, faas, and heroku entities in favor of narrower entities with identifying attributes semantic-conventions#4169
- v2: Remove the AWS ECS entity in favor of task, cluster, and container entities semantic-conventions#4170
- v2: Remove the AWS log entity semantic-conventions#4171
- v2: Remove browser entity in favor of a public attribute group semantic-conventions#4172
- v2: Remove gcp.gce and gcp.cloud_run entities in favor of narrower entities, define identifying attributes for GCP entities semantic-conventions#4173
I think ok to merge this as-is but wanted to mention in case you'd prefer to hold for those changes.
Member
Author
There was a problem hiding this comment.
I think those changes would likely be included in the next semantic convention release yeah? If so, then we won't actually publish these new entity constants until updating to the latest semconv release with those changes. So no harm done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the pattern of #483, #489. Starting with incubating only.
cc @trask, @lmolkova