Repository navigation
Conversation
thswlsqls
marked this pull request as ready for review
October 18, 2026 13:07
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-18 13:36 UTC Review the latest changes. Non-blocking check failure: codecov/patch Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8962 +/- ##
=========================================
Coverage 90.40% 90.41%
- Complexity 10898 10900 +2
=========================================
Files 1015 1015
Lines 29843 29844 +1
Branches 3896 3897 +1
=========================================
+ Hits 26981 26982 +1
Misses 1910 1910
Partials 952 952 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8960
Description
JdkHttpSender.toHttpResponse()threwUnsupportedContentEncodingExceptionbeforetry (InputStream rawIs = response.body()), so theBodyHandlers.ofInputStream()body was never closed. Its Javadoc requires reading to EOF or callingclose()to release the exchange.try (InputStream ignored = response.body()). Exception type, message, and non-retryable handling are unchanged.OkHttpHttpSender.handleResponse()already does this check insidetry (ResponseBody body = ...).ofInputStream()both came in Response body bounds #8224. Internal package; no apidiff.Testing done
JdkHttpSenderTest#sendInternal_unsupportedContentEncoding_closesBody: a mockedContent-Encoding: brresponse must throw and close the body. With the main-code fix reverted, it fails on the close assertion.:exporters:sender:jdk:check: spotless, ErrorProne/NullAway and jApiCmp pass; 14 of 15 tests pass.sendInternal_RetryableConnectTimeoutExceptionalso fails on unmodifiedmainhere, because my VPN routes10.255.255.1.