Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-17 02:30 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8954 +/- ##
============================================
+ Coverage 90.65% 90.67% +0.01%
- Complexity 10889 10893 +4
============================================
Files 1015 1015
Lines 29741 29741
Branches 3878 3878
============================================
+ Hits 26963 26967 +4
Misses 1860 1860
+ Partials 918 914 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jkwatson
reviewed
Oct 16, 2026
Comment on lines
+279
to
+280
| + method.methodName().stringValue() | ||
| + method.methodType().stringValue(); |
Contributor
There was a problem hiding this comment.
tiniest nit: I know this is just a key, but maybe a ':' in between the method and type?
jkwatson
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we use java 25 for the build, we can drop the asm dependency and in favor of built in java.lang.classfile.* classes.