Repository navigation
Conversation
thswlsqls
marked this pull request as ready for review
October 12, 2026 02:13
Pull request dashboard statusMerged · refreshed 2026-10-15 21:51 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8933 +/- ##
=========================================
Coverage 90.65% 90.66%
- Complexity 10887 10888 +1
=========================================
Files 1015 1015
Lines 29731 29733 +2
Branches 3876 3876
=========================================
+ Hits 26953 26956 +3
Misses 1860 1860
+ Partials 918 917 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
psx95
reviewed
Oct 12, 2026
psx95
approved these changes
Oct 12, 2026
Show that a key with an underscore, such as otel.experimental.sdk.jvm_stacktrace, matches the environment variable OTEL_EXPERIMENTAL_SDK_JVM_STACKTRACE. Requested in review. Javadoc only, no behavior change. Generated-by: Claude Code
jack-berg
approved these changes
Oct 15, 2026
Contributor
|
Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8932
Description
ConfigUtil.getStringnormalized the lookup key withnormalizePropertyKey(keeps_) but env var names withnormalizeEnvironmentVariableKey(turns_into.), so keys containing_never matched an env var.OTEL_EXPERIMENTAL_SDK_JVM_STACKTRACE=truewas ignored, while the system propertyotel.experimental.sdk.jvm_stacktraceworked.normalizeEnvironmentVariableKeybefore comparing it with env var names. Keys without_behave the same as before.getStringJavadoc to match.Testing done
config_keyassertion toConfigUtilTest#getString_EnvironmentVariable(the build setsCONFIG_KEY=environment). It fails without the fix ("default") and passes with it../gradlew :common:checkpassed (9 tests)../gradlew :sdk:common:testpassed (346 tests).