Repository navigation
Include B3 debug header in multi-header propagation fields - #8930
Open
kamikazeayoup wants to merge 1 commit into
Open
kamikazeayoup wants to merge 1 commit into
kamikazeayoup wants to merge 1 commit into
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-12 19:11 UTC Investigate required status check failures. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8930 +/- ##
=========================================
Coverage 90.65% 90.65%
Complexity 10887 10887
=========================================
Files 1015 1015
Lines 29731 29732 +1
Branches 3876 3876
=========================================
+ Hits 26953 26954 +1
Misses 1860 1860
Partials 918 918 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The B3 multi-header propagator injects
X-B3-Flagsfor debug requests but omits it from fields().The propagator documentation instructs callers to clear these fields before reusing a carrier. Because the debug header is missing from the list, it survives cleanup and can cause a subsequent unsampled request to be treated as sampled.
Changes
Add
B3Propagator.DEBUG_HEADERtoFIELDSso callers can clear it before reusing a carrier.Update
fieldsList_multiInjectto include the debug header and addinject_ReusedCarrier_DoesNotRetainDebugFlagto verify that a reused carrier does not retain the previous request’s debug flag.Validation
./gradlew :extensions:trace-propagators:checkpassed locally../gradlew nativeTest --no-configuration-cache --no-parallelpassed locally with Oracle GraalVM25.0.4+7.1, the same version used by CI.The GraalVM 25 compilation error reported in CI did not reproduce in this local run.