Repository navigation
Conversation
thswlsqls
marked this pull request as ready for review
October 9, 2026 01:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8921 +/- ##
============================================
+ Coverage 90.62% 90.64% +0.01%
- Complexity 10876 10879 +3
============================================
Files 1015 1015
Lines 29712 29720 +8
Branches 3874 3874
============================================
+ Hits 26927 26939 +12
+ Misses 1868 1863 -5
- Partials 917 918 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull request dashboard statusMerged · refreshed 2026-10-09 16:21 UTC Status above doesn't look right?
|
jack-berg
approved these changes
Oct 9, 2026
Contributor
|
Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8919
Description
DeclarativeConfigPropertyUtil.toMapfound each value's type by callinggetString,getBoolean,getLongandgetDoublein turn.YamlDeclarativeConfigPropertieslogsIgnoring value for key [...]for each mismatched call, so valid values likeratio: 0.25orenabled: trueproduced false warnings.isString/isBoolean/isLong/isDoublefirst. These match the types each getter accepts, so the resulting map is unchanged (integers are still returned asLong).jaeger_remote.initial_samplerandInstrumentationConfigUtil.getInstrumentationConfigModel.getScalarList, because there is no list introspection API.is<Type>methods), DeclarativeConfigProperties: no way to coerce types without triggering warnings #8101.Testing done
DeclarativeConfigPropertyUtilTest#toMap_doesNotLogTypeWarnings(string, boolean, integer, double, nested map, string list, list of maps): asserts map values and types, and that noYamlDeclarativeConfigPropertieswarnings are logged../gradlew :api:incubator:checkpassed (98 tests intest, 4 intestConvertToModel).