Repository navigation
Avoid shared internal code in sdk-common and api-incubator (#6970) - #8916
Merged
jack-berg merged 1 commit intoOct 9, 2026
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-09 16:22 UTC Status above doesn't look right?
|
rooks-ns
marked this pull request as draft
October 8, 2026 15:17
rooks-ns
force-pushed
the
fix/avoid-shared-internal-sdk-common
branch
from
October 8, 2026 15:53
44cd646 to
3cb5e4e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8916 +/- ##
============================================
- Coverage 90.65% 90.64% -0.01%
- Complexity 10856 10863 +7
============================================
Files 1014 1014
Lines 29643 29654 +11
Branches 3858 3860 +2
============================================
+ Hits 26872 26881 +9
- Misses 1859 1860 +1
- Partials 912 913 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rooks-ns
force-pushed
the
fix/avoid-shared-internal-sdk-common
branch
2 times, most recently
from
October 8, 2026 19:22
56852e8 to
a466245
Compare
rooks-ns
marked this pull request as ready for review
October 8, 2026 19:53
rooks-ns
force-pushed
the
fix/avoid-shared-internal-sdk-common
branch
from
October 8, 2026 20:39
a466245 to
911d8ed
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6970.
Eliminates
:sdk:common's dependencies onio.opentelemetry.api.internal.{Utils, StringUtils}via localized validation guards, enabling bothopentelemetry-sdk-commonandopentelemetry-api-incubatorto be unexempted inNoSharedInternalCodeTest.Changes
NoSharedInternalCodeTest: Removedopentelemetry-sdk-commonandopentelemetry-api-incubatorfrom exemptions.RetryPolicy: LocalizedcheckArgumentinRetryPolicyBuilder.AttributeCheckUtil: Inlined argument check and localizedisPrintableString.ResourceBuilder: Inlined null/empty schema URL check.SdkEntityBuilder: LocalizedcheckArgument.ResourceTest: Added attribute key validation unit tests.