Repository navigation
Conversation
The index sent Interrail holders to SNCF Connect for every operator and said every train needs a paid reservation, which is wrong for ICE within Germany, Dutch domestic trains, Swiss and Irish trains and more. Each operator's index entry now carries its own booking site and a note on which of its trains need a reservation; an operator without one falls back to general rules pointing at Interrail's reservations page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
index.jsonsent Interrail holders to SNCF Connect for all nine operators. It also said every train needs a paid pass-holder reservation, which is wrong for ICE within Germany, Dutch domestic trains, most Swiss trains, Irish Rail and others.After: each operator's Interrail entry links to that operator's own booking site, for example int.bahn.de, ns.nl, trenitalia.com or vy.no. Its note says which of its trains need a reservation, for example "ICE, IC and EC trains within Germany need no reservation" or "Frecciarossa… need a paid pass-holder reservation. Regionale… don't". An operator without its own entry falls back to Interrail's reservations page and a general note. Sweden and Great Britain already have entries for when their feeds go live.
How: the new
src/operators/interrail.tsholds the booking site and note per operator.buildOperatorApilays them over the general Interrail info. The notes are written from the operators' published pass rules, so a quick check before sharing them widely is worthwhile.Checked:
npm run check(27 tests, including the per-operator link, its note and the fallback) and the fixture build'sindex.json.Generated by Claude Code