19.0 tutorial delje by Delvaux-Jean-Baptiste · Pull Request #1415 · odoo/tutorials

Delvaux-Jean-Baptiste · 2026-09-15T11:17:43Z

[REF] Updated branch name
[FIX] Added extra end of file line

robodoo · 2026-09-15T11:17:46Z

msho-odoo

@Delvaux-Jean-Baptiste
Nice job on the branch situation 🔥

For the commit message we write in a way that aligns with when this commit is merged it will .....
so you might change [IMP] estate: Added models to something like [IMP] estate: add estate property model or however you like to describe your changes :)
refer to Git Guidlines

but really nice job, well done 👍
also left some comments for you to check

msho-odoo · 2026-09-15T11:28:18Z

+    bedrooms= fields.Integer()
+    living_area= fields.Integer()
+    facades= fields.Integer()
+    garage= fields.Boolean()


Good practice to have boolean fields on the form is_something or has_something so you might change this to has_garden and has_garage

msho-odoo · 2026-09-15T11:30:33Z

+    facades= fields.Integer()
+    garage= fields.Boolean()
+    garden= fields.Boolean()
+    garden_orientation= fields.Selection(string='Type',


It's good, but it's better to commit to a convention and follow it all the way, so for example in this field you wrote the attribute string before ='Type' but you didn't do that in name field Char('Estate Name')

msho-odoo · 2026-09-15T11:35:34Z

+    garden_orientation= fields.Selection(string='Type',
+                                        selection=[('east', 'East'),
+                                                    ('west', 'West'),
+                                                    ('north', 'North'),
+                                                    ('south', 'South')
+                                                    ]
+                                        )


It's correct but we style it like this (see the suggestion).

nitpick: some teams might stick to single quotes being only on technical strings (the ones that the user don't see) and double quotes are for the strings that the user can see)
so for example the selection can be ('east', "East") instead of ('east', 'East') but some teams don't do this, they just stick to their own convention which is all single quotes (if possible) or all double quotes

Suggested change

garden_orientation= fields.Selection(string='Type',

selection=[('east', 'East'),

('west', 'West'),

('north', 'North'),

('south', 'South')

]

)

garden_orientation= fields.Selection(

string='Type',

selection=[

('east', 'East'),

('west', 'West'),

('north', 'North'),

('south', 'South'),

]

)

msho-odoo · 2026-09-15T11:38:00Z

+    _name = "estate_property"
+    _description = "The details of a property"
+
+    name= fields.Char('Estate Name', required= True)


We do spaces before and after the operator so it's name = fields not name= fields.
Better to check all style errors in your runbot and fix it :)
The log there provides a description for the reason of the error

[ADD] estate: add estate access for base users

msho-odoo · 2026-09-15T14:39:22Z

@Delvaux-Jean-Baptiste please mention me here when you think the PR is ready for another review, typically, after each chapter :)
Also remember to check the runbot for styling issues 😉

added fields and default values in fields of new estate [IMP] estate: updated gitignore to exclude vs config

Delvaux-Jean-Baptiste · 2026-09-15T15:19:30Z

@msho-odoo I believe I am ready for the last review of the day ;-)

[IMP] estate: Update List, Form and Search for cleaner display

msho-odoo

Thanks for the good work!

Regarding the commit message we use [ADD] for adding whole new modules, but in this case (adding some field, view or feature/logic) we use [IMP] tag (for improvement) which you will be using most of the time in your team :)

I also left you some comments to check and please Always remember to green your runbot before pinging of the review 😉

msho-odoo · 2026-09-16T08:59:04Z

-    expected_price = fields.Float(required = True)
-    selling_price = fields.Float()
-    bedrooms = fields.Integer()
+    date_availability = fields.Date(copy=False, default=fields.Date.today()+relativedelta(months=3))


directly valuating the fields.Date at default will work when imported but it will be stuck at this value, you should use lambda function. Search the codebase for it and let me know if you have any question :)

msho-odoo · 2026-09-16T09:08:46Z

 .mypy_cache/
 .dmypy.json
 dmypy.json



ops, I shouldn't see this file here :)
environmental files like this one (or .vscode) for example shouldn't be pushed with your commit

@Delvaux-Jean-Baptiste still can see the file 👀

Created offers Created tags

added computed field on offer validity added onchange on has_garden

Added the accept offer and refuse offer to offers

and expected price Added python constrains on Selling price Added Unique constrains on tags and types

Delvaux-Jean-Baptiste · 2026-09-18T07:29:06Z

@msho-odoo I may or may not have forgotten to ask for review ysterday....
Anyway, chapters 7 to 10 are in here ;-)

msho-odoo

Thank you for your work!

Don't forget to add the module name in your [FIX] commits as well and follow the git guidelines with the message.

Left you some comments, but please apply the comments whenever they apply, I might have not pointed every point in every file, but if one of my comments apply in some other file, apply it there as well (like the translation _ on every error message)

Thanks, keep it up 🔥

msho-odoo · 2026-09-18T09:32:57Z

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <menuitem id="estate_menu_root" name="Real Estate">


this one slipped out of the naming convention :)

@msho-odoo Could you point me at which naming convention? I looked into a few other add-ons and I couldn't find some sort of pattern

msho-odoo · 2026-09-18T09:35:41Z

+    <record id="estate_property_tag_view_list" model="ir.ui.view">
+        <field name="name">estate.property.tag.list</field>
+        <field name="model">estate_property_tag</field>
+        <field name="arch" type="xml">
+            <list string="Tags">
+                <field string="Tags" name="name"/>
+            </list>
+        </field>
+    </record>
+
+    <!-- Form View -->
+    <record id="estate_property_tag_form" model="ir.ui.view">
+        <field name="name">estate.property.tag.form</field>
+        <field name="model">estate_property_tag</field>
+        <field name="arch" type="xml">
+            <form>
+                <sheet>
+                    <h1><field name="name"></field></h1>
+                </sheet>
+            </form>
+        </field>
+    </record>


Is it needed to add such views for list and form view to add changes to them? I am not sure if a chapter asks you to edit something in them but if not then you have them by default

I believe it was asked at some point to put a list. I know it is by default, but I do believe it asked for a custom one for some reason.

msho-odoo · 2026-09-18T09:39:35Z

 .mypy_cache/
 .dmypy.json
 dmypy.json



@Delvaux-Jean-Baptiste still can see the file 👀

per estate_type

offers too low.

Delvaux-Jean-Baptiste · 2026-09-21T12:44:20Z

@msho-odoo New release. Fixed as much as I could. What I haven't fixed I don't know how to, I'd be gad to have some guidance ;-)
How can I remove the gitignore file for example?

Delvaux-Jean-Baptiste added 2 commits September 15, 2026 10:42

[ADD] Add the basic setup for the estate module

63c3ad3

[IMP] estate: Added models

92218f6

msho-odoo marked this pull request as ready for review September 15, 2026 11:24

[FIX] Made field mandatory

2e76d0b

msho-odoo requested changes Sep 15, 2026

View reviewed changes

Delvaux-Jean-Baptiste added 2 commits September 15, 2026 14:10

[FIX] Styling issues

a2ee7f4

[ADD] estate: add estate access for base users

[FIX] formatting issues

2b37ba8

[ADD] estate: Added menus in app

52aac90

added fields and default values in fields of new estate [IMP] estate: updated gitignore to exclude vs config

[ADD] estate: Added garden area field

861aa17

[IMP] estate: Update List, Form and Search for cleaner display

msho-odoo requested changes Sep 16, 2026

View reviewed changes

Delvaux-Jean-Baptiste added 8 commits September 17, 2026 09:44

[IMP] estate: Added buyers, salespersons, tags and offers

6d3ba96

Created offers Created tags

[FIX] corrections of a couple of wrong names

fc7c422

[FIX] Added missing keys in manifest

dce0b63

[FIX] Removed unnecessary tracking in salesperson_id

0a6d7d5

[IMP] estate: added computed fields on total_area and best price

679e80d

added computed field on offer validity added onchange on has_garden

[IMP] estate: Added Cancel and Sold buttons to estate

85e2b75

Added the accept offer and refuse offer to offers

[IMP] estate: Added SQL constrains on selling price

a5cbecd

and expected price Added python constrains on Selling price Added Unique constrains on tags and types

[FIX] Correction of Self inside loop

70a196a

msho-odoo requested changes Sep 18, 2026

View reviewed changes

Delvaux-Jean-Baptiste added 4 commits September 21, 2026 10:12

[IMP] estate: Added smart button for offer's list

6fd1163

per estate_type

[IMP] estate: Updated create offers to not allow

200c5f7

offers too low.

[FIX] estate: Fixed inherit of res.users

b3d2416

[FIX] estate: duplicat string in model and views

1718f4e

[ADD] estate: add tests (not functional yet)

4e38e81

Conversation

Delvaux-Jean-Baptiste commented Sep 15, 2026

Uh oh!

robodoo commented Sep 15, 2026

Uh oh!

msho-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msho-odoo commented Sep 15, 2026

Uh oh!

Delvaux-Jean-Baptiste commented Sep 15, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Delvaux-Jean-Baptiste commented Sep 18, 2026

Uh oh!

msho-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Delvaux-Jean-Baptiste commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

msho-odoo left a comment •

edited

Loading